✨ Add --target flag to logs for metrics and dockerd#14
Merged
Conversation
Resolve the log path via config.MustResolve("logging", target+"_file")
so the YAML logging group is the registry — no internal target map.
--target is long-form only (no short alias); invalid targets are
rejected with the same slices.Contains + PrintErrorWithOptions pattern
as --level. Bare `ws-cli logs` keeps reading the main log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ws-cli logs --target=<main|metrics|docker>so the metrics exporterand in-container Docker daemon logs are inspectable through the same
surface as
workspace.log.logger.NewReader(tail, level, target)resolves the path viaconfig.MustResolve("logging", target+"_file")— the YAMLlogginggroup is the registry, no internal target map.
--targetis long-form only (no short alias); invalid targets arerejected with the same
slices.Contains+styles.PrintErrorWithOptionspattern as
--level.ws-cli logskeeps reading the main log (default--target=main).PR-1 of the lockstep pair (workspace consumes the new tag + adds the
WS_LOGGING_{METRICS,DOCKER}_FILEenv vars).