This repository was archived by the owner on Jun 11, 2025. It is now read-only.
🏷️ Fixed some types to make more clear#10
Merged
nxtcoder17 merged 3 commits intoJun 23, 2023
Conversation
updated some types inside nodepool of operator clusters for the awsnodeconfig.
karthik1729
suggested changes
Jun 22, 2023
|
|
||
| // aws -> CloudProvider | ||
| NodeConfig string `json:"nodeConfig"` | ||
| // NodeConfig string `json:"nodeConfig"` |
Contributor
Author
There was a problem hiding this comment.
deleted these comments
By Mistake there was NadeName, so fixed it to NodeName and made changes accordingly.
there was some extra comments which are no more needed so deleted those comments.
abdheshnayak
pushed a commit
that referenced
this pull request
Nov 5, 2024
router spec updated, things kind of work
abdheshnayak
added a commit
that referenced
this pull request
Nov 5, 2024
* 🏷️ Fixed some types to make more clear updated some types inside nodepool of operator clusters for the awsnodeconfig. * ✏️ Fixed typos: NadeName -> NodeName in clusters/v1 By Mistake there was NadeName, so fixed it to NodeName and made changes accordingly. * 💡 Removed some unwanted comments there was some extra comments which are no more needed so deleted those comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated some types inside nodepool of operator clusters for the awsnodeconfig.