This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Feature/cluster management#16
Merged
nxtcoder17 merged 9 commits intoJul 13, 2023
Merged
Conversation
finalizers was not that much efficient for the node and nodepool controller of clustersv1, so improved and now expected to be run perfectly.
added support to create create cluster from platform cluster for the cloud provider aws and work in progress.
improved finalizers for the cluster/v1 controllers so we can perform deletion of cluster and node also as per requirement.
now nodes can be deleted forcefully in case of requred without draining, and deleting from the cluster. it will try to drain and delete node from the cluster and ignore if any errors comes. force delete can be trigger by adding the label `kloudlite.io/force-delete: "true"`.
added diffrent controller for the resource clusterv1/cluster which will be used for the target cluster, it is responsible for the fetching all the ips of nodes present on the cluster and also responisble for ensuring deletion of the all nodepools before it get deleted.
after the completion of feature, manual test done and found some bugs in clustersv1 so resolved those bugs.
as byoc will be not used in comming version byoc is replaced with cluster resource of clusterv1.
nxtcoder17
reviewed
Jul 13, 2023
| ctx, obj := req.Context(), req.Object | ||
|
|
||
| // fetch the nodepool | ||
| cl, err := rApi.Get(ctx, r.Client, fn.NN("", obj.Spec.NodePoolName), &clustersv1.Cluster{}) |
Member
There was a problem hiding this comment.
fetching nodepool, then type should have been &clustersv1.NodePool, not clustersv1.Cluster ?
nxtcoder17
reviewed
Jul 13, 2023
Member
nxtcoder17
left a comment
nxtcoder17
left a comment
There was a problem hiding this comment.
- folder names should be of format -, no underscores in there
- test files in
operators/clusters/internal/controllers/**should be deleted if outdated
previous code was under development so left lots of conventions to follow, modified all the blocks which are not in conventions.
due to update for the conventions there was some import error.
abdheshnayak
pushed a commit
that referenced
this pull request
Nov 5, 2024
fixes infinite reconcilation because of bad path to secret file in te…
abdheshnayak
added a commit
that referenced
this pull request
Nov 5, 2024
* ⚡ Finalizers of cluster's nodepool and node improved in controller finalizers was not that much efficient for the node and nodepool controller of clustersv1, so improved and now expected to be run perfectly. * ✨ Added support to create cluster from platform cluster with cp aws added support to create create cluster from platform cluster for the cloud provider aws and work in progress. * ⚡ Finalizers are improved for the clusters/v1 controllers improved finalizers for the cluster/v1 controllers so we can perform deletion of cluster and node also as per requirement. * ✨ Force delete support for the clustersv1/nodes added now nodes can be deleted forcefully in case of requred without draining, and deleting from the cluster. it will try to drain and delete node from the cluster and ignore if any errors comes. force delete can be trigger by adding the label `kloudlite.io/force-delete: "true"`. * ✨ Cluster controller added for the target controller added diffrent controller for the resource clusterv1/cluster which will be used for the target cluster, it is responsible for the fetching all the ips of nodes present on the cluster and also responisble for ensuring deletion of the all nodepools before it get deleted. * 🐛 Resolved bugs in clustersv1 found while manual testing after the completion of feature, manual test done and found some bugs in clustersv1 so resolved those bugs. * 🎨 Cluster resource added in place of byoc resource of clusterv1 as byoc will be not used in comming version byoc is replaced with cluster resource of clusterv1. * 💡 Modified the code styles according to conventions. previous code was under development so left lots of conventions to follow, modified all the blocks which are not in conventions. * 🐛 Import by wrong name due to update for the conventions there was some import error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: