This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Feature/route53#17
Merged
nxtcoder17 merged 4 commits intoJul 17, 2023
Merged
Conversation
…er platform_controller as we are using route53 as dns management, route53 management utils added in pkg/aws and using that utils ips of cluster upserted to the route53.
as modifications done in cluster_types of cluster/v1. custom resource definitions updated.
mistakenly secret for route53 on platrom controller of clusterv1/cluster was reading from the target_cluster secret file. so mistake is corrected now and it's reading the secret of aws for route53 on platfrom cluster/ controller of clusterv1 from environment of operator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we are using route53 as DNS management, route53 management utils are added to pkg/aws and used those utils to upsert cluster ips of all nodes to a route53 record with the host like ..hostedzone.