This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Refactorings/controller and templates#25
Merged
nxtcoder17 merged 3 commits intoAug 1, 2023
Merged
Conversation
- add or chart repo prechecks if it is stored in cache and then adds, which is faster than adding and then checking - removed function EnsureRelease, and came up with opts params for InstallOrUpgrade
- adds workspace name label to workspace's target namespapce - adds project name labels to project's target namespace - adds observability annotations template, that is as of now used in app template, but is available to use in helm charts for managed resources as well - removes unncessary stdout logs from without-kubectl.go
longer description
abdheshnayak
pushed a commit
that referenced
this pull request
Nov 5, 2024
* refactor(pkg/hel): helm client refactorings (#101) - add or chart repo prechecks if it is stored in cache and then adds, which is faster than adding and then checking - removed function EnsureRelease, and came up with opts params for InstallOrUpgrade * refactor(operators,templates): adds observability annotations - adds workspace name label to workspace's target namespapce - adds project name labels to project's target namespace - adds observability annotations template, that is as of now used in app template, but is available to use in helm charts for managed resources as well - removes unncessary stdout logs from without-kubectl.go * refactor: package updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request includes several significant changes and enhancements to the codebase. The following commits are part of this pull request:
Helm client refactorings
EnsureReleaseand introducedoptsparams forInstallOrUpgrade.Adds observability annotations
without-kubectl.go.go modules updates
These changes significantly improve the codebase's functionality and maintainability. The refactorings in the Helm client optimize the adding process of chart repos and enhance the upgrade process. Additionally, the introduction of observability annotations improves tracking and monitoring of workspaces, projects and apps