This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Bug/nodepools new node creation#34
Merged
nxtcoder17 merged 6 commits intoOct 28, 2023
Merged
Conversation
- nodepool controller, whenever target updates, creates clustersv1.Node object, which is then managed by node controller - autoscaling job, though will be managed by nodepool controller only - only role of clustersv1.Node CRD and its controller is to manage deletion lifecycle of real corev1.Node, like draining and deleting it after sometime in future - cluster autoscaler will also delete `clustersv1.Node` object, whenever it needs to downscale the cluster, and update nodepool`s target size
- this custom ready annotation, adds extra metadata to ready info - it adds lastReadyGeneration, which is the generation of the last successful reconcile, and also deletion info, if resource is being deleted
…pdates - renamed iac to templates - req.PostReconcile() now sets additional annotations and status fields that are used by printcolumns on types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(operators/clusters): cluster job template, CRD, and printcolumn updates (Commit 4604bea):
req.PostReconcile()function now sets additional annotations and status fields used by print columns on various types.fix(operators/nodepool): nodepool controller and new print columns (Commit 6d1840e):
chore(config/crd/bases): updates because of .status.lastReadyGeneration (Commit a3accdb):
.status.lastReadyGeneration.feat(pkg/operator): post-reconcile func, adds custom ready annotation (Commit a3accdb):
lastReadyGeneration, which tracks the generation of the last successful reconcile, and provides deletion information if a resource is being deleted.feat: kloudlite banner displays binary built time (Commit 78338cf):
feat(operators/nodepool): nodepool now creates clustersv1.Node objects (Commit 937732d):
clustersv1.Nodeobjects, which are then managed by the node controller.clustersv1.NodeCRD and its controller is to manage the deletion lifecycle of realcorev1.Nodeobjects, including draining and eventual deletion.clustersv1.Nodeobjects as needed to downscale the cluster and update the nodepool's target size.These changes collectively improve the functionality and robustness of the system.