This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Feat/single operator binary#40
Merged
Merged
Conversation
- separately running and managing each operator is good for development but not for production. - using the same codebase, this single monolith operator, just attaches to all the controllers and runs them in a single binary. - refactorings, and code changes to accomodate this change are in this commit. github-issue: #37
- cluster controllers, now assume role to create resources - account s3 buckets controller, for aws cloud provider, now assumes role to create s3 buckets on tenant cluster - nodepool controller, uses IAM instance profile, to assume role to create resources on tenant cluster - (pkg/logging): log line trimmed by removing caller info, unless explicitly passed through options - (pkg/operator): added event predicate to filter out events from non-tenant cluster namespaces github-issue: #38
- all the reconcilation schemes, and binding controllers to the manager has been abstracted into a separate package in each of the operators
- helm chart operator now run jobs in the same namepsace the helm chart
resource has been created
- RBAC handling has been updated, to work like this:
+ new service account helm-job-svc-account is created in each
namespace where helm-chart reosurce exists
+ cluster role binding is created only once when it does not exist,
and the other times it is patched when the desired svc account is
not listed in cluster role binding subjects
- better handling of isReady, and lastReadyGeneration - profiling library to make it easy to profile cpu and memory, instead of googling everytime
- redpanda operator needs to have bash, and rpk binaries, adds them to our base image -
- graphql tag "noinput" to status types in crdsv1 types
Signed-off-by: Anshuman Bhaskar <nxtcoder17@gmail.com>
abdheshnayak
pushed a commit
that referenced
this pull request
Nov 5, 2024
Feat/single operator binary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes:
fixes #37
fixes #38
fix(apis/crds): adding graphql tags to types (Commit ca20ff7):
fix(cmd/platform-operator): fixes Container image (Commit 4228be0):
rpkbinaries, ensuring proper functionality.fix(pkg/operator): updates to PostReconcile log (Commit 8adacb8):
isReadyandlastReadyGeneration.fix(operators/helm-charts): job RBAC updates (Commit a436391):
helm-job-svc-account) in each namespace where the Helm chart resource exists.refactor: changes to achieve single binary (Commit 58d8d90):
feat(operators/clusters, nodepool): AWS assume role (Commit 6086f3c):
feat: cmd/platform-operator is a single binary for operators (Commit 5498509):
These changes collectively enhance the functionality, maintainability, and performance of the codebase.