Merged
Conversation
But I am not sure if it is more elegant than simply updating the inner __dict__.
…into didip-persistent-state
didip
reviewed
Jun 19, 2019
| class aMiddleware(BaseHTTPMiddleware): | ||
| async def dispatch(self, request, call_next): | ||
| request.state.foo = expected_value1 | ||
| print("a", dict(request)) |
Contributor
There was a problem hiding this comment.
Don't you want to remove these print statements?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #552
Adds
request.scopeandrequest.state.Middleware now passes scope in-place.
Closes #545
Closes #551
Closes #552
At a later point we'll also want to start moving towards deprecating the request-as-dict interface, in favor of
request.scope.