Fix elecstate energy unit test link dependencies#2
Merged
kluonju merged 1 commit intoMay 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
elecstate::H_Hartree_pw::v_hartreeandelecstate::makov_payne_correctionwhen building theMODULE_ESTATE_elecstate_energyunit test by ensuring the test links the planewave implementation and compiles the provider sources.Description
source/source_estate/test/CMakeLists.txtto addplanewave_serialto theLIBSforMODULE_ESTATE_elecstate_energyand to include../makov_payne.cppand../module_pot/H_Hartree_pw.cppin the testSOURCESso the missing symbols are defined at link time.Testing
git diff --check, which passed; attempted to configure the test build withcmake -DBUILD_TESTING=ON -DENABLE_MPI=ONbut configuration failed due to missing MPI; a secondcmakeattempt with-DENABLE_MPI=OFFfailed due to missing FFTW3, so a full build/test could not be completed in this environment.Codex Task