Open
Conversation
This was referenced Apr 17, 2026
added 2 commits
April 17, 2026 09:57
scrollback: Use a standard double linked list instead of open coding it everywhere. selection: Use the same line pointer, if the line is in the screen or in the scrollback. This greatly simplify the code. Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
Make sure posx and posy are on the screen, before setting the selection. Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
added 3 commits
April 17, 2026 10:14
This remove some duplicated code Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
Add a generic function to get the next selection line, and use that to count and copy the lines, regardless if they are in the scrollback buffer or not. Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
added 2 commits
April 17, 2026 11:31
Otherwise the selection pointers may point to the other screen lines which can cause problems when trying to copy. Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
The scrollback is only for the main screen. Also remove the reset from the tests, as its not necessary, and now reset the scrollback. Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scrollback/selection: refactor scrollback and selection code
scrollback: Use a standard double linked list instead of open
coding it everywhere.
selection: Use the same line pointer, if the line is in the screen
or in the scrollback. This greatly simplify the code.
Fix kmscon/kmscon#330