Skip to content

Commit ee46b3d

Browse files
committed
Fix blank UI on forms pages when there are no public lists
1 parent c90d42a commit ee46b3d

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

frontend/src/views/Forms.vue

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,13 @@
22
<section class="forms content relative">
33
<h1 class="title is-4">{{ $t('forms.title') }}</h1>
44
<hr />
5+
56
<b-loading v-if="loading.lists" :active="loading.lists" :is-full-page="false" />
7+
<p v-else-if="publicLists.length === 0">
8+
{{ $t('forms.noPublicLists') }}
9+
</p>
10+
11+
612
<div class="columns" v-else-if="publicLists.length > 0">
713
<div class="column is-4">
814
<h4>{{ $t('forms.publicLists') }}</h4>

i18n/en.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@
9292
"email.unsubHelp": "Don't want to receive these e-mails?",
9393
"forms.formHTML": "Form HTML",
9494
"forms.formHTMLHelp": "Use the following HTML to show a subscription form on an external webpage. The form should have the email field and one or more `l` (list UUID) fields. The name field is optional.",
95+
"forms.noPublicLists": "There are no public lists to generate a forms.",
9596
"forms.publicLists": "Public lists",
9697
"forms.publicSubPage": "Public subscription page",
9798
"forms.selectHelp": "Select lists to add to the form.",
@@ -257,12 +258,12 @@
257258
"public.privacyWipe": "Wipe your data",
258259
"public.privacyWipeHelp": "Delete all your subscriptions and related data from the database permanently.",
259260
"public.sub": "Subscribe",
260-
"public.subTitle": "Subscribe",
261-
"public.subName": "Name (optional)",
262261
"public.subConfirmed": "Subscribed successfully.",
263262
"public.subConfirmedTitle": "Confirmed",
263+
"public.subName": "Name (optional)",
264264
"public.subNotFound": "Subscription not found.",
265265
"public.subPrivateList": "Private list",
266+
"public.subTitle": "Subscribe",
266267
"public.unsub": "Unsubscribe",
267268
"public.unsubFull": "Also unsubscribe from all future e-mails.",
268269
"public.unsubHelp": "Do you want to unsubscribe from this mailing list?",
@@ -273,10 +274,10 @@
273274
"settings.duplicateMessengerName": "Duplicate messenger name: {name}",
274275
"settings.errorEncoding": "Error encoding settings: {error}",
275276
"settings.errorNoSMTP": "At least one SMTP block should be enabled",
276-
"settings.general.enablePublicSubPage": "Enable public subscription page",
277-
"settings.general.enablePublicSubPageHelp": "Show a public subscription page with all the public lists for people to subscribe.",
278277
"settings.general.adminNotifEmails": "Admin notification e-mails",
279278
"settings.general.adminNotifEmailsHelp": "Comma separated list of e-mail addresses to which admin notifications such as import updates, campaign completion, failure etc. should be sent.",
279+
"settings.general.enablePublicSubPage": "Enable public subscription page",
280+
"settings.general.enablePublicSubPageHelp": "Show a public subscription page with all the public lists for people to subscribe.",
280281
"settings.general.faviconURL": "Favicon URL",
281282
"settings.general.faviconURLHelp": "(Optional) full URL to the static favicon to be displayed on user facing view such as the unsubscription page.",
282283
"settings.general.fromEmail": "Default `from` email",

0 commit comments

Comments
 (0)