Skip to content

Commit fd31ac6

Browse files
committed
Remove redundant send_later param in campaign POST/PUT.
1 parent e8fd12b commit fd31ac6

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

cmd/campaigns.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ import (
2424
type campaignReq struct {
2525
models.Campaign
2626

27-
// Indicates if the "send_at" date should be written or set to null.
28-
SendLater bool `json:"send_later"`
29-
3027
// This overrides Campaign.Lists to receive and
3128
// write a list of int IDs during creation and updation.
3229
// Campaign.Lists is JSONText for sending lists children
@@ -269,7 +266,7 @@ func handleUpdateCampaign(c echo.Context) error {
269266
o = c
270267
}
271268

272-
out, err := app.core.UpdateCampaign(id, o.Campaign, o.ListIDs, o.MediaIDs, o.SendLater)
269+
out, err := app.core.UpdateCampaign(id, o.Campaign, o.ListIDs, o.MediaIDs)
273270
if err != nil {
274271
return err
275272
}

frontend/src/views/Campaign.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,6 @@ export default Vue.extend({
497497
messenger: this.form.messenger,
498498
type: 'regular',
499499
tags: this.form.tags,
500-
send_later: this.form.sendLater,
501500
send_at: this.form.sendLater ? this.form.sendAtDate : null,
502501
headers: this.form.headers,
503502
template_id: this.form.templateId,
@@ -521,7 +520,6 @@ export default Vue.extend({
521520
messenger: this.form.messenger,
522521
type: 'regular',
523522
tags: this.form.tags,
524-
send_later: this.form.sendLater,
525523
send_at: this.form.sendLater ? this.form.sendAtDate : null,
526524
headers: this.form.headers,
527525
template_id: this.form.templateId,

internal/core/campaigns.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,9 @@ func (c *Core) CreateCampaign(o models.Campaign, listIDs []int, mediaIDs []int)
208208
}
209209

210210
// UpdateCampaign updates a campaign.
211-
func (c *Core) UpdateCampaign(id int, o models.Campaign, listIDs []int, mediaIDs []int, sendLater bool) (models.Campaign, error) {
211+
func (c *Core) UpdateCampaign(id int, o models.Campaign, listIDs []int, mediaIDs []int) (models.Campaign, error) {
212+
sendLater := o.SendAt.Valid
213+
212214
_, err := c.q.UpdateCampaign.Exec(id,
213215
o.Name,
214216
o.Subject,

0 commit comments

Comments
 (0)