Skip to content

Added function insertBatch to insert multiple values#21

Merged
Zetaphor merged 6 commits into
knadh:masterfrom
subhashdasyam:master
Nov 23, 2016
Merged

Added function insertBatch to insert multiple values#21
Zetaphor merged 6 commits into
knadh:masterfrom
subhashdasyam:master

Conversation

@subhashdasyam

Copy link
Copy Markdown
Contributor

Added function insertBatch to insert multiple values

@subhashdasyam subhashdasyam mentioned this pull request Nov 17, 2016
removed unnecessary lines
@Zetaphor

Copy link
Copy Markdown
Collaborator

At first glance this looks good overall. Could you please clean up the merge conflict on the README?

Also, and I'm not sure if this is me being nitpicky, but adding your name to the credit header in simplemysql.py seems unnecessary. I have write access on this repo and my name isn't in there, and neither is the name of any other contributors. I'm open to discussion on this, as I'm not sure what the de-facto standard is for this situation.

@Zetaphor Zetaphor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your copy so your changes are added to the latest revision of this file

@Zetaphor Zetaphor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your copy so your changes are added to the latest revision of this file

@subhashdasyam

Copy link
Copy Markdown
Contributor Author

Ahh I am sorry, that was my local copy which i uploaded, i keep track of files with my name, i will understand for which i have contributed.
I will remove the name from simplemysql

Removed name

@subhashdasyam subhashdasyam left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Removed Name

@subhashdasyam

subhashdasyam commented Nov 23, 2016

Copy link
Copy Markdown
Contributor Author

Can some one please merge this issue.

@Zetaphor Zetaphor merged commit 51e0d0b into knadh:master Nov 23, 2016
@Zetaphor

Copy link
Copy Markdown
Collaborator

Merge complete, thank you for this contribution! Next time please make sure your fork is up to date with master so we don't keep having to resolve these README conflicts ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants