Skip to content

New markdown link checker and linter are overly sensitive #750

@samodell

Description

@samodell

Many PRs in the Docs repo right now have build test failures when it seems like they shouldn't.

Causes:

  • Oversensitive link verification, such as serving/samples: remove EXPOSE directive from helloworld #644 (more details in the comments of that PR; but to summarize, one link is valid and causing a failure, and one link is to a http://localhost URL, which we should probably exclude from link checks)

  • Unknown: I can't see a root cause for some failures, such as Add link to image in Dockerhub #747
    Error logs are vague:
    I0110 23:28:45.331] ============================
    I0110 23:28:45.332] ==== BUILD TESTS FAILED ====
    I0110 23:28:45.332] ============================
    W0110 23:28:45.363] Run: ('/workspace/./test-infra/jenkins/../scenarios/../hack/coalesce.py',)
    E0110 23:28:45.363] Command failed
    I0110 23:28:45.363] process 643 exited with code 1 after 0.7m
    E0110 23:28:45.363] FAIL: pull-knative-docs-build-tests

CC @srinivashegde86 @jessiezcc @adrcunha

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions