Skip to content

Conversation

@steren
Copy link
Contributor

@steren steren commented Jan 10, 2019

Mainly for consistency with other samples.

Mainly for consistency with other samples.
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2019
@samodell
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell, steren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adrcunha
Copy link
Contributor

Build tests are failing because:

I0110 23:28:26.564] serving/samples/helloworld-go/README.md:141: MD007 Unordered list indentation

Open the full log and you'll see this line.

@steren
Copy link
Contributor Author

steren commented Jan 12, 2019

I do not see what's wrong on line 141.

Please send a commit in the branch to fix the issue, as I do not know how to fix this.

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2019
@samodell
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2019
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2019
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2019
@samodell
Copy link
Contributor

The documentation for the linter says that 2 spaces must be used for indented items in a list, but if you do that, it breaks the numbering for the ordered list, and the linter still had complaints about list formatting.

@adrcunha Is there a way to disable the linter but keep the link checker active? We have the Prettier bot, which does a lot of the same markdown improvements and wasn't impeding workflow.

@samodell
Copy link
Contributor

/retest

@samodell
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2019
@knative-prow-robot knative-prow-robot merged commit 2078ae3 into master Jan 15, 2019
@steren steren deleted the steren-go-dockerhub branch January 23, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants