-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add link to image in Dockerhub #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Mainly for consistency with other samples.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: samodell, steren The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build tests are failing because: Open the full log and you'll see this line. |
|
I do not see what's wrong on line 141. Please send a commit in the branch to fix the issue, as I do not know how to fix this. |
|
/lgtm |
|
The documentation for the linter says that 2 spaces must be used for indented items in a list, but if you do that, it breaks the numbering for the ordered list, and the linter still had complaints about list formatting. @adrcunha Is there a way to disable the linter but keep the link checker active? We have the Prettier bot, which does a lot of the same markdown improvements and wasn't impeding workflow. |
|
/retest |
|
/lgtm |
Mainly for consistency with other samples.