Skip to content

address wrong manifest in gcppubsub sample #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2019
Merged

address wrong manifest in gcppubsub sample #1273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/eventing/samples/gcp-pubsub-source/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ source is most useful as a bridge from other GCP services, such as
namespace `default`, feel free to change to any other namespace you would
like to use instead:

```shell
kubectl label namespace default knative-eventing-injection=enabled
```
```shell
kubectl label namespace default knative-eventing-injection=enabled
```

1. Create a GCP PubSub Topic. If you change its name (`testing`), you also need
to update the `topic` in the
Expand Down Expand Up @@ -128,7 +128,7 @@ We will verify that the published message was sent into the Knative eventing
system by looking at the logs of the function subscribed to the `pubsub-test`
channel.

The function and the subscription were created by applying the `subscriber.yaml`
The function and the subscription were created by applying the [`trigger.yaml`](./trigger.yaml)
manifest in the [deployment](#deployment) section above.

1. We need to wait for the downstream pods to get started and receive our event,
Expand Down