Add a SinkBinding sample. #2008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
size/L
This is largely derived from the ContainerSource docs, but using SinkBinding and a CronJob.
mattmoor
force-pushed
the
sinkbinding-sample
branch
from
8835e09 to
23bcbd9
Compare
matzew
reviewed
Dec 2, 2019
|
|
||
| The SinkBinding can be used to author new event sources using any of the | ||
| familiar compute abstractions that Kubernetes makes available (e.g. Deployment, | ||
| Job, DaemonSet, StatefulSet), or Knative abstractions (e.g. Service, |
There was a problem hiding this comment.
add CronJob, since that is used in the sample ?
There was a problem hiding this comment.
CronJob actually isn't PodSpecable, we are binding the Jobs it creates.
|
All pre-reqs are in. |
knative-prow-robot
removed
the
do-not-merge/hold
n3wscott
reviewed
Dec 2, 2019
n3wscott
reviewed
Dec 2, 2019
| @@ -0,0 +1,17 @@ | |||
| apiVersion: sources.eventing.knative.dev/v1alpha1 | |||
n3wscott
reviewed
Dec 2, 2019
| @@ -0,0 +1,34 @@ | |||
| apiVersion: batch/v1beta1 | |||
|
/lgtm |
knative-prow-robot
added
do-not-merge/hold
|
/lgtm |
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely derived from the ContainerSource docs, but
using SinkBinding and a CronJob.
/hold
This needs the following related PRs to land: