Rename eventing release artifacts release.yaml => eventing.yaml #2103
Conversation
knative-prow-robot
added
the
size/M
| - https://github.com/knative/serving/releases/download/{{< version >}}/monitoring-tracing-zipkin.yaml | ||
| - https://github.com/knative/serving/releases/download/{{< version >}}/monitoring-tracing-zipkin-in-mem.yaml | ||
| - **Eventing Component**: | ||
| - https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml |
There was a problem hiding this comment.
Just to make sure I understand, @yolocs -- going forward, the only artifact released for eventing will be eventing.yaml, and it will come bundled with the in-memory channel provisioner? No more option to install it separately?
There was a problem hiding this comment.
Cool, just wanted to make sure I understood what was changing :) I'll wait to merge this until the Eventing PR is merged.
There was a problem hiding this comment.
FYI. The eventing PR has been merged.
There was a problem hiding this comment.
the only artifact released for eventing will be eventing.yaml, and it will come bundled with the in-memory channel provisioner? No more option to install it separately?
No, this is incorrect. There will still be 3 artifacts:
eventing-core.yamlwill be just the eventing core without InMemoryChannel, equivalent to the previouseventing.yaml
in-memory-channel.yamlwill be just the InMemoryChannel, unchangedeventing.yamlwill be eventing-core.yaml and in-memory-channel.yaml combined, equivalent to the previousrelease.yaml
There was a problem hiding this comment.
If I understand it correctly, only eventing.yaml will actually be useful, right? I don't see serving list serving-core.yaml here.
There was a problem hiding this comment.
You're right, serving-core.yaml isn't documented here so eventing-core.yaml can also be undocumented. I was just answering @samodell's question about installing separately. That option will still exist, even if undocumented.
There was a problem hiding this comment.
Thanks for clarifying.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: samodell, yolocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Fixes knative/eventing#1987
Eventing PR: knative/eventing#2382
Proposed Changes