Skip to content

Rename eventing release artifacts release.yaml => eventing.yaml #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Rename eventing release artifacts release.yaml => eventing.yaml #2103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/eventing/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@ If the `knative-eventing` namespace or the `imc-controller-*` does not exist, us

```sh
kubectl apply --selector knative.dev/crd-install=true \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml
```

1. Finish installing Eventing resources by running the following command:

```sh
kubectl apply --filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml
kubectl apply --filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml
```

Installing the CRDs first can prevent race conditions, which might cause failures during the install.
Expand Down
8 changes: 3 additions & 5 deletions docs/install/Knative-custom-install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,7 @@ The following Knative installation files are available:
- https://github.com/knative/serving/releases/download/{{< version >}}/monitoring-tracing-zipkin.yaml
- https://github.com/knative/serving/releases/download/{{< version >}}/monitoring-tracing-zipkin-in-mem.yaml
- **Eventing Component**:
- https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml
Copy link
Contributor

@samodell samodell Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure I understand, @yolocs -- going forward, the only artifact released for eventing will be eventing.yaml, and it will come bundled with the in-memory channel provisioner? No more option to install it separately?

Copy link
Contributor Author

@yolocs yolocs Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's my understanding. @grantr

Copy link
Contributor

@samodell samodell Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, just wanted to make sure I understood what was changing :) I'll wait to merge this until the Eventing PR is merged.

Copy link
Contributor Author

@yolocs yolocs Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI. The eventing PR has been merged.

Copy link
Contributor

@grantr grantr Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only artifact released for eventing will be eventing.yaml, and it will come bundled with the in-memory channel provisioner? No more option to install it separately?

No, this is incorrect. There will still be 3 artifacts:

  • eventing-core.yaml will be just the eventing core without InMemoryChannel, equivalent to the previous eventing.yaml
    in-memory-channel.yaml will be just the InMemoryChannel, unchanged
  • eventing.yaml will be eventing-core.yaml and in-memory-channel.yaml combined, equivalent to the previous release.yaml

Copy link
Contributor Author

@yolocs yolocs Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand it correctly, only eventing.yaml will actually be useful, right? I don't see serving list serving-core.yaml here.

Copy link
Contributor

@grantr grantr Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, serving-core.yaml isn't documented here so eventing-core.yaml can also be undocumented. I was just answering @samodell's question about installing separately. That option will still exist, even if undocumented.

Copy link
Contributor Author

@yolocs yolocs Jan 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying.

- https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml
- https://github.com/knative/eventing/releases/download/{{< version >}}/in-memory-channel.yaml
- **Eventing Resources**:
- https://github.com/knative/eventing-contrib/releases/download/{{< version >}}/github.yaml
- https://github.com/knative/eventing-contrib/releases/download/{{< version >}}/camel.yaml
Expand Down Expand Up @@ -200,7 +198,7 @@ commands below.

```bash
https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml
https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml
https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml
https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand Down Expand Up @@ -246,14 +244,14 @@ commands below.
```bash
kubectl apply --selector knative.dev/crd-install=true \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml
```

1. Remove the `--selector knative.dev/crd-install=true` flag
to install all the Knative components and the Eventing resources:
```bash
kubectl apply --filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml
```

1. Run one or more of the following commands to ensure that your component or plugin was
Expand Down
4 changes: 2 additions & 2 deletions docs/install/Knative-with-AKS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ your Knative installation, see
```bash
kubectl apply --selector knative.dev/crd-install=true \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand All @@ -179,7 +179,7 @@ your Knative installation, see

```bash
kubectl apply --filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand Down
4 changes: 2 additions & 2 deletions docs/install/Knative-with-GKE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ see [Performing a Custom Knative Installation](./Knative-custom-install.md).
```bash
kubectl apply --selector knative.dev/crd-install=true \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand All @@ -175,7 +175,7 @@ see [Performing a Custom Knative Installation](./Knative-custom-install.md).

```bash
kubectl apply --filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand Down
4 changes: 2 additions & 2 deletions docs/install/Knative-with-Gardener.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ see [Performing a Custom Knative Installation](./Knative-custom-install.md).
```bash
kubectl apply --selector knative.dev/crd-install=true \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand All @@ -130,7 +130,7 @@ see [Performing a Custom Knative Installation](./Knative-custom-install.md).

```bash
kubectl apply --filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand Down
4 changes: 2 additions & 2 deletions docs/install/Knative-with-ICP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ see [Performing a Custom Knative Installation](./Knative-custom-install.md).
```

```shell
curl -L https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
curl -L https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
| sed 's/LoadBalancer/NodePort/' \
| kubectl apply --filename -
```
Expand Down Expand Up @@ -221,7 +221,7 @@ curl -L https://github.com/knative/serving/releases/download/{{< version >}}/ser
```

```shell
curl -L https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
curl -L https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
| sed 's/LoadBalancer/NodePort/' \
| kubectl delete --filename -
```
Expand Down
4 changes: 2 additions & 2 deletions docs/install/Knative-with-IKS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ see [Performing a Custom Knative Installation](./Knative-custom-install.md).
```bash
kubectl apply --selector knative.dev/crd-install=true \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand All @@ -214,7 +214,7 @@ see [Performing a Custom Knative Installation](./Knative-custom-install.md).

```bash
kubectl apply --filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand Down
4 changes: 2 additions & 2 deletions docs/install/Knative-with-Minikube.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ see [Performing a Custom Knative Installation](./Knative-custom-install.md).
```shell
kubectl apply --selector knative.dev/crd-install=true \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand All @@ -124,7 +124,7 @@ see [Performing a Custom Knative Installation](./Knative-custom-install.md).

```shell
kubectl apply --filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand Down
4 changes: 2 additions & 2 deletions docs/install/Knative-with-PKS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ see [Performing a Custom Knative Installation](./Knative-custom-install.md).
```bash
kubectl apply --selector knative.dev/crd-install=true \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand All @@ -110,7 +110,7 @@ see [Performing a Custom Knative Installation](./Knative-custom-install.md).

```bash
kubectl apply --filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand Down
4 changes: 2 additions & 2 deletions docs/install/Knative-with-any-k8s.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ your Knative installation, see
```bash
kubectl apply --selector knative.dev/crd-install=true \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand All @@ -60,7 +60,7 @@ your Knative installation, see

```bash
kubectl apply --filename https://github.com/knative/serving/releases/download/{{< version >}}/serving.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/release.yaml \
--filename https://github.com/knative/eventing/releases/download/{{< version >}}/eventing.yaml \
--filename https://github.com/knative/serving/releases/download/{{< version >}}/monitoring.yaml
```

Expand Down