Skip to content

Update Source docs to make the migration from CronJobSource to PingSource more clear. #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 13, 2020
Merged

Update Source docs to make the migration from CronJobSource to PingSource more clear. #2296

merged 4 commits into from
Mar 13, 2020

Conversation

@evankanderson
Copy link
Member

@evankanderson evankanderson commented Mar 10, 2020 •
edited
Loading

Partial fix for #2275

Proposed Changes

  • Update CronJobSource to indicate that it is deprecated and completely replaced in 0.13 by PingSource or CronJob + SinkBinding.
  • Update ContainerSource to indicate that it is deprecated and completely replaced in 0.13 by SinkBinding.
  • Fix up autogeneration scripts
  • Fix a typo I noticed after approving Source migrations #2275

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 10, 2020

@evankanderson: The label(s) /label cherrypick-0.13 cannot be applied. These labels are supported: proposal/0.11, proposal/0.12, proposal/0.13, proposal/0.14, proposal/0.15, proposal/0.16, proposal/0.17, proposal/0.18, proposal/0.19, channel/kafka, channel/natss, source/awssqs, source/camel, source/ceph, source/couchdb, source/github, source/kafka, source/prometheus

In response to this:

Partial fix for #2275

Proposed Changes

  • Update CronJobSource to indicate that it is deprecated and completely replaced in 0.13 by PingSource or CronJob + SinkBinding.
  • Fix up autogeneration scripts
  • Fix a typo I noticed after approving Source migrations #2275

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 10, 2020
@evankanderson
Copy link
Member Author

evankanderson commented Mar 10, 2020

/assign @n3wscott @matzew

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 10, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 10, 2020

@evankanderson: The label(s) /label cherrypick-0.13 cannot be applied. These labels are supported: proposal/0.11, proposal/0.12, proposal/0.13, proposal/0.14, proposal/0.15, proposal/0.16, proposal/0.17, proposal/0.18, proposal/0.19, channel/kafka, channel/natss, source/awssqs, source/camel, source/ceph, source/couchdb, source/github, source/kafka, source/prometheus

In response to this:

Partial fix for #2275

Proposed Changes

  • Update CronJobSource to indicate that it is deprecated and completely replaced in 0.13 by PingSource or CronJob + SinkBinding.
  • Update ContainerSource to indicate that it is deprecated and completely replaced in 0.13 by SinkBinding.
  • Fix up autogeneration scripts
  • Fix a typo I noticed after approving Source migrations #2275

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@evankanderson
Copy link
Member Author

evankanderson commented Mar 10, 2020

I updated ContainerSource, too, since it was also pointing to a broken link.

@evankanderson
Copy link
Member Author

evankanderson commented Mar 10, 2020

The two broken links are waiting on netlify propagated of #2275

@evankanderson
Copy link
Member Author

evankanderson commented Mar 12, 2020

Actually, this is waiting on #2306 to make the docs show up on the 0.13 release branch.

@evankanderson
Copy link
Member Author

evankanderson commented Mar 13, 2020

/retest

@n3wscott
Copy link
Contributor

n3wscott commented Mar 13, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2020
@knative-prow-robot knative-prow-robot merged commit b5807dc into knative:master Mar 13, 2020
evankanderson pushed a commit to evankanderson/docs that referenced this pull request Mar 13, 2020
Update Source docs to make the migration from CronJobSource to PingSo…
176adc3 
…urce more clear. (knative#2296)

* Fix typo in CronJobSource

* Fix paths after migration

* Update CronJobSource to indicate that it is deprecated and replaced by PingSource or CronJob + SinkBinding

* Update docs to not that ContainerSource is also deprecated
@evankanderson evankanderson mentioned this pull request Mar 13, 2020
Merged
knative-prow-robot pushed a commit that referenced this pull request Mar 20, 2020
Update Source docs to make the migration from CronJobSource to PingSo…
7da0dff 
…urce more clear. (#2296) (#2312)

* Fix typo in CronJobSource

* Fix paths after migration

* Update CronJobSource to indicate that it is deprecated and replaced by PingSource or CronJob + SinkBinding

* Update docs to not that ContainerSource is also deprecated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grantr grantr Awaiting requested review from grantr

@matzew matzew Awaiting requested review from matzew

Assignees

@matzew matzew

@n3wscott n3wscott

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@evankanderson @knative-prow-robot @n3wscott @matzew @googlebot