Skip to content

Source migrations #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 10, 2020
Merged

Source migrations #2275

merged 5 commits into from
Mar 10, 2020

Conversation

@matzew
Copy link
Member

@matzew matzew commented Mar 5, 2020 •
edited
Loading

Proposed Changes

  • adding migrations for PingSource
  • adding migration for SinkBinding

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 5, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 5, 2020
@matzew matzew force-pushed the migration_guides branch from 6f11a0e to f559a97 Compare March 5, 2020 17:27
@matzew
Copy link
Member Author

matzew commented Mar 5, 2020

/cc @samodell
/cc @abrennan89

abrennan89
abrennan89 reviewed Mar 5, 2020
View reviewed changes
abrennan89
abrennan89 reviewed Mar 5, 2020
View reviewed changes
abrennan89
abrennan89 reviewed Mar 5, 2020
View reviewed changes
abrennan89
abrennan89 reviewed Mar 5, 2020
View reviewed changes
abrennan89
abrennan89 reviewed Mar 5, 2020
View reviewed changes
abrennan89
abrennan89 reviewed Mar 5, 2020
View reviewed changes
abrennan89
abrennan89 reviewed Mar 5, 2020
View reviewed changes
abrennan89
abrennan89 reviewed Mar 5, 2020
View reviewed changes
abrennan89
abrennan89 suggested changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some review comments @matzew

@matzew
Copy link
Member Author

matzew commented Mar 5, 2020 via email

@matzew
Copy link
Member Author

matzew commented Mar 5, 2020

Added some review comments @matzew

will address them - thanks for looking.

I guess I will just update this PR tomorrow and than also add the other migration

@matzew matzew force-pushed the migration_guides branch from f559a97 to a7e13ff Compare March 6, 2020 13:40
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2020
@matzew matzew force-pushed the migration_guides branch from a7e13ff to a859df4 Compare March 9, 2020 11:11
lionelvillard
lionelvillard reviewed Mar 9, 2020
View reviewed changes
docs/eventing/migration/ping.md Outdated
jsonData: '{"message": "Hello world!"}'
sink:
ref:
apiVersion: serving.knative.dev/v1
Copy link
Contributor

@lionelvillard lionelvillard Mar 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent is wrong here

@matzew
Copy link
Member Author

matzew commented Mar 9, 2020

/cc @n3wscott
/cc @lionelvillard
/cc @vaikas

@matzew
Addressing feedback
b886d86 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
This was referenced Mar 9, 2020
Merged
Closed
@n3wscott
Copy link
Contributor

n3wscott commented Mar 10, 2020

This PR needs a better title

n3wscott
n3wscott reviewed Mar 10, 2020
View reviewed changes
docs/eventing/migration/ping.md
metadata:
name: ping-source
spec:
schedule: "* * * * *"
Copy link
Contributor

@n3wscott n3wscott Mar 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can drop this, it is * * * * * by default now in v1alpha2.

@n3wscott
Copy link
Contributor

n3wscott commented Mar 10, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@matzew matzew changed the title some first migration Source migrations Mar 10, 2020
@evankanderson
Copy link
Member

evankanderson commented Mar 10, 2020

/approve

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, evankanderson, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit be1eb29 into knative:master Mar 10, 2020
@evankanderson evankanderson mentioned this pull request Mar 10, 2020
Merged
evankanderson pushed a commit to evankanderson/docs that referenced this pull request Mar 12, 2020
@matzew
Source migrations (knative#2275)
28202f9 
* some first migration

* Addressing comment from Ashleigh's review

* Adding SinkBinding migration doc

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* fix the ko:// by removing...

* Addressing feedback

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
This was referenced Mar 12, 2020
Merged
Merged
knative-prow-robot pushed a commit that referenced this pull request Mar 12, 2020
@matzew
Cherry-pick 0.13 migration docs to 0.13 release branch (#2306)
3062f1d 
* Source migrations (#2275)

* some first migration

* Addressing comment from Ashleigh's review

* Adding SinkBinding migration doc

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* fix the ko:// by removing...

* Addressing feedback

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* 💄 adding the SinkBinding bits to the index file as well... (#2297)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
@evankanderson evankanderson mentioned this pull request Mar 13, 2020
Merged
@abrennan89 abrennan89 mentioned this pull request Jun 11, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@nachocano nachocano Awaiting requested review from nachocano

@samodell samodell Awaiting requested review from samodell

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@vaikas vaikas Awaiting requested review from vaikas

3 more reviewers

@mattmoor mattmoor mattmoor left review comments

@n3wscott n3wscott n3wscott left review comments

@abrennan89 abrennan89 abrennan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@n3wscott n3wscott

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@matzew @n3wscott @evankanderson @knative-prow-robot @mattmoor @lionelvillard @abrennan89 @googlebot