Skip to content

Conversation

@evankanderson
Copy link
Member

Fixes #2275

Proposed Changes

  • Remove cronjob-source example
  • Add an alias to redirect from cronjob-source to ping-source

(I'm still testing that aliases work as I understand from the docs)
/assign @n3wscott

@knative-prow-robot
Copy link
Contributor

@evankanderson: The label(s) /label cherrypick-0.13 cannot be applied. These labels are supported: proposal/0.11, proposal/0.12, proposal/0.13, proposal/0.14, proposal/0.15, proposal/0.16, proposal/0.17, proposal/0.18, proposal/0.19, channel/kafka, channel/natss, source/awssqs, source/camel, source/ceph, source/couchdb, source/github, source/kafka, source/prometheus

In response to this:

Fixes #2275

Proposed Changes

  • Remove cronjob-source example
  • Add an alias to redirect from cronjob-source to ping-source

(I'm still testing that aliases work as I understand from the docs)
/assign @n3wscott

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 12, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2020
@n3wscott
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2020
@knative-prow-robot knative-prow-robot merged commit da6d4b8 into knative:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants