Skip to content

[RELEASE 0.13] CP of: Make documentation for PingSource. (#2126) #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[RELEASE 0.13] CP of: Make documentation for PingSource. (#2126) #2309

wants to merge 1 commit into from

Conversation

@vaikas
Copy link
Contributor

@vaikas vaikas commented Mar 13, 2020

Cherry pick of: #2126

Fixes: #2294

  • Document ping source.

  • Squashed commit of the following:

commit 9a04cb6
Author: Scott Nichols snichols@vmware.com
Date: Thu Feb 27 07:32:03 2020 -0800

Document ping source.

  • typo on source.

  • update image

  • kail tabs

  • by name default

Fixes #issue-number or description of the problem the PR solves

Proposed Changes

@n3wscott @vaikas
Make documentation for PingSource. (knative#2126)
b30da7f 
* Document ping source.

* Squashed commit of the following:

commit 9a04cb6
Author: Scott Nichols <snichols@vmware.com>
Date:   Thu Feb 27 07:32:03 2020 -0800

    Document ping source.

* typo on source.

* update image

* kail tabs

* by name default
@googlebot
Copy link

googlebot commented Mar 13, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Mar 13, 2020
@knative-prow-robot knative-prow-robot added approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 13, 2020
@n3wscott
Copy link
Contributor

n3wscott commented Mar 13, 2020

@googlebot I consent.

/lgtm
/approve
THANKS!!!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vaikas
Copy link
Contributor Author

vaikas commented Mar 13, 2020

@googlebot I fixed it.

@n3wscott
Copy link
Contributor

n3wscott commented Mar 13, 2020

@googlebot I fixed it.

🖕 🖕 🖕

@vaikas
Copy link
Contributor Author

vaikas commented Mar 13, 2020

@googlebot I consent.

@vaikas
Copy link
Contributor Author

vaikas commented Mar 13, 2020

Superceded by #2310 due to CLA unhappiness...

@vaikas vaikas closed this Mar 13, 2020
@vaikas vaikas deleted the pingsource-cp branch March 13, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew Awaiting requested review from matzew

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@n3wscott n3wscott

Labels

cla: no Indicates the PR's author has not signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vaikas @googlebot @n3wscott @knative-prow-robot