Skip to content

Conversation

@vaikas
Copy link
Contributor

@vaikas vaikas commented Mar 13, 2020

Cherry pick of: #2126

Fixes: #2294

Document ping source.

Fixes #issue-number or description of the problem the PR solves

Proposed Changes

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 13, 2020
@knative-prow-robot knative-prow-robot added approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 13, 2020
@n3wscott
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 026a353 into knative:release-0.13 Mar 13, 2020
@vaikas vaikas deleted the pingsource-cp-2 branch March 13, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants