Skip to content

Conversation

@evankanderson
Copy link
Member

I'll need to update this again when #2387 lands.

Fixes Markdown_Link error in community/samples https://prow.knative.dev/view/gcs/knative-prow/pr-logs/pull/knative_docs/2396/pull-knative-docs-markdown-link-check/1253615911399591937

Proposed Changes

  • Points to the rendered page on knative.dev; this will be moving back into the docs repo soon-ish, and I'll need to figure out how to hande it then, probably by changing the website build to not canonicalize https://github.com/... links.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 30, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 30, 2020
@mpetason
Copy link
Contributor

mpetason commented May 1, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2020
@knative-prow-robot knative-prow-robot merged commit b106a5b into knative:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants