Update contributing docs #2387

evankanderson · 2020-04-13T20:23:51Z

The docs contribution information used to be mixed with the general community information, and was moved to https://github.com/knative/community when that was split out.

With the Hugo build, there's no reason for the contributing docs not to live in the docs repo.

Fixes #1917 #2322

Proposed Changes

Move docs from https://github.com/knative/community to this repo

evankanderson · 2020-04-14T21:11:04Z

Verified that the website actually renders fine, not the errors shown in https://docs-2387.default.docs-on-the-rocks.io/community/contributing/

evankanderson · 2020-04-14T21:13:51Z

/assign @carieshmarie @abrennan89

evankanderson · 2020-04-20T21:21:52Z

/assign @abrennan89

abrennan89

A few small nits, but overall this looks fantastic! Thanks @evankanderson 🥳

CONTRIBUTING.md

evankanderson · 2020-04-30T23:13:25Z

@abrennan89 This is ready for another look

CONTRIBUTING.md

abrennan89 · 2020-05-04T13:09:22Z

CONTRIBUTING.md

+2. Use the [correct template](https://github.com/knative/docs/issues/new) for
+   your new issue. There are two templates available:
+   - **Bug report**: If you're reporting an error in the existing documentation,
+     use this template. This could be anything from broken samples to typos.


What is a broken sample? Should this maybe be broken link instead?

A broken sample would presumably be one of the code samples which no longer compiles or works properly due to ecosystem changes.

abrennan89 · 2020-05-04T13:10:24Z

CONTRIBUTING.md

+meets weekly on Tuesdays and alternates between a 9am PT and a 4:30pm PT time to
+accommodate contributors in both the EMEA and APAC timezones.


The meeting is only at 9am now I think (11.30am CDT)?

9:30am, corrected. We seem to have lost the afternoon meeting that was the other weeks. Given the current level of WG activity, this seems reasonable. Updated.

abrennan89 · 2020-05-04T13:11:08Z

CONTRIBUTING.md

+meets weekly on Tuesdays and alternates between a 9am PT and a 4:30pm PT time to
+accommodate contributors in both the EMEA and APAC timezones.
+[Click here](https://calendar.google.com/calendar/embed?src=google.com_18un4fuh6rokqf8hmfftm5oqq4%40group.calendar.google.com)
+to see the exact dates on the Knative working group calendar. If you're


Maybe split this into a new paragraph to make it more readable?

CONTRIBUTING.md

abrennan89

couple of very minor things, otherwise lgtm!

jonatasbaldin · 2020-05-05T07:17:56Z

w00t w00t, amazing work @evankanderson ✨

googlebot · 2020-05-05T12:53:41Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

evankanderson · 2020-05-05T12:56:36Z

@abrennan89 -- have you been added to the red hat/Google CLA list?

I may back out there last two suggestions and apply them as my own commits to move this forward.

…e/community

googlebot · 2020-05-06T17:37:57Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

evankanderson · 2020-05-06T17:40:26Z

Updated and CLA looks good. I'll need an /lgtm for this to be submitted.

CONTRIBUTING.md

googlebot · 2020-05-14T20:11:08Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-05-14T20:11:08Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-05-14T20:15:44Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

evankanderson · 2020-05-14T20:15:58Z

I backed out the suggestions so I don't have to do the CLA-bot, and made the changes myself (and squashed the commits to make the log nicer).

knative-prow-robot · 2020-05-14T20:21:17Z

@evankanderson: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-knative-docs-markdown-link-check	`7da72f8`	link	`/test pull-knative-docs-markdown-link-check`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

evankanderson · 2020-05-14T20:35:25Z

The link check is fixed by #2468

vaikas · 2020-05-26T17:43:24Z

/lgtm
/approve

knative-prow-robot · 2020-05-26T17:43:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [evankanderson,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 13, 2020

mattmoor reviewed Apr 13, 2020

View reviewed changes

knative-prow-robot requested review from RichieEscarez and carieshmarie April 13, 2020 20:24

knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved labels Apr 13, 2020

evankanderson force-pushed the a-contribution branch from eace36e to 2f3f903 Compare April 13, 2020 20:26

mattmoor reviewed Apr 13, 2020

View reviewed changes

evankanderson force-pushed the a-contribution branch from 7c682fe to 73eccaf Compare April 13, 2020 20:43

knative-prow-robot assigned abrennan89 and carieshmarie Apr 14, 2020

abrennan89 reviewed Apr 20, 2020

View reviewed changes

evankanderson mentioned this pull request Apr 30, 2020

Update link to point to website contributing guidelines for now. #2427

Merged

abrennan89 reviewed May 4, 2020

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

abrennan89 reviewed May 4, 2020

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

abrennan89 reviewed May 4, 2020

View reviewed changes

googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels May 5, 2020

evankanderson force-pushed the a-contribution branch from 353cede to 7c82285 Compare May 6, 2020 17:32

mattmoor reviewed May 6, 2020

View reviewed changes

Evan Anderson added 3 commits May 6, 2020 10:35

Update contributing docs and move back from https://github.com/knativ…

fc894c9

…e/community

Fix misspellings and trailing whitespace

a7c7c25

Fix broken links

8325698

evankanderson force-pushed the a-contribution branch from 7c82285 to d7be5df Compare May 6, 2020 17:37

googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels May 6, 2020

mpetason reviewed May 12, 2020

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

mpetason reviewed May 12, 2020

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels May 14, 2020

Incorporate suggestions from abrennan89

7da72f8

evankanderson force-pushed the a-contribution branch from fcca3fd to 7da72f8 Compare May 14, 2020 20:15

googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels May 14, 2020

knative-prow-robot assigned vaikas May 26, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2020

knative-prow-robot merged commit 23c337c into knative:master May 26, 2020

abrennan89 mentioned this pull request Jun 11, 2020

Add abrennan89 to doc-approvers #2579

Merged

3 tasks

		meets weekly on Tuesdays and alternates between a 9am PT and a 4:30pm PT time to
		accommodate contributors in both the EMEA and APAC timezones.

Update contributing docs #2387

Update contributing docs #2387

Uh oh!

Conversation

evankanderson commented Apr 13, 2020

Proposed Changes

Uh oh!

evankanderson commented Apr 14, 2020

Uh oh!

evankanderson commented Apr 14, 2020

Uh oh!

evankanderson commented Apr 20, 2020

Uh oh!

abrennan89 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

evankanderson commented Apr 30, 2020

Uh oh!

Uh oh!

abrennan89 May 4, 2020

Choose a reason for hiding this comment

Uh oh!

evankanderson May 5, 2020

Choose a reason for hiding this comment

Uh oh!

evankanderson May 5, 2020

Choose a reason for hiding this comment

Uh oh!

abrennan89 May 4, 2020

Choose a reason for hiding this comment

Uh oh!

evankanderson May 6, 2020

Choose a reason for hiding this comment

Uh oh!

abrennan89 May 4, 2020

Choose a reason for hiding this comment

Uh oh!

evankanderson May 6, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

abrennan89 left a comment

Choose a reason for hiding this comment

Uh oh!

jonatasbaldin commented May 5, 2020

Uh oh!

googlebot commented May 5, 2020

Uh oh!

evankanderson commented May 5, 2020

Uh oh!

googlebot commented May 6, 2020

Uh oh!

evankanderson commented May 6, 2020

Uh oh!

Uh oh!

Uh oh!

googlebot commented May 14, 2020

Uh oh!

googlebot commented May 14, 2020

Uh oh!

googlebot commented May 14, 2020

Uh oh!

evankanderson commented May 14, 2020

Uh oh!

knative-prow-robot commented May 14, 2020

Uh oh!

evankanderson commented May 14, 2020

Uh oh!

vaikas commented May 26, 2020

Uh oh!

knative-prow-robot commented May 26, 2020