Skip to content

Conversation

@nak3
Copy link
Contributor

@nak3 nak3 commented Aug 1, 2020

The latest broker's URL is different.

$ kubectl get broker -n event-example
NAME      READY   REASON   URL                                                                              AGE
default   True             http://broker-ingress.knative-eventing.svc.cluster.local/event-example/default   37m

It seems that knative/eventing@8a541e9 changed it, so this patch updates the doc.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 1, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nak3
To complete the pull request process, please assign lionelvillard
You can assign the PR to them by writing /assign @lionelvillard in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 1, 2020
@nak3
Copy link
Contributor Author

nak3 commented Aug 1, 2020

/assign @lionelvillard

@nak3
Copy link
Contributor Author

nak3 commented Aug 3, 2020

It seems only 0.15 doc #2585 had the fix.

@grantr
Copy link
Contributor

grantr commented Aug 20, 2020

Sorry @nak3, this one fell off my radar. Looks like #2758 fixed the broker URLs and generated the conflict here. This PR has a few additional changes to the event-display output examples. If you want to get those in, please rebase, but I don't think they're required. Feel free to close instead.

@knative-prow-robot
Copy link
Contributor

@nak3: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2020
@nak3
Copy link
Contributor Author

nak3 commented Aug 20, 2020

Sure, no problem. Let's close this.

@nak3 nak3 closed this Aug 20, 2020
@nak3 nak3 deleted the fix-broker-url branch August 22, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants