Skip to content

Conversation

@zhongduo
Copy link
Contributor

Fixes #2757

Proposed Changes

  • Update broker url in docs/eventing/getting-started.md, as the default url is now http://broker-ingress.knative-eventing.svc.cluster.local/event-example/default.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 18, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 18, 2020
@zhongduo
Copy link
Contributor Author

/cc @vaikas

Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eventing/Getting Started doesn't mention that broker classes may have different URIs

4 participants