Skip to content

Comments

ignore some java related files#3015

Merged
knative-prow-robot merged 2 commits intoknative:masterfrom
csantanapr:gitignore-java-files
Nov 7, 2020
Merged

ignore some java related files#3015
knative-prow-robot merged 2 commits intoknative:masterfrom
csantanapr:gitignore-java-files

Conversation

@csantanapr
Copy link
Member

my OCD in me can't stand this little thing.

My vscode keeps creating system files

@knative-prow-robot knative-prow-robot added approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2020
@csantanapr
Copy link
Member Author

/assign @mattmoor

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 7, 2020
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csantanapr, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [csantanapr,mattmoor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 2abdd26 into knative:master Nov 7, 2020
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Mar 6, 2021
* ignore some java related files

* adding new line just in case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants