Skip to content

Conversation

julz
Copy link
Contributor

@julz julz commented Nov 12, 2020

Adds tab with install instructions for the new optional/alpha DomainMapping feature.

See also #3017.

/assign @mpetason @abrennan89

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 12, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 12, 2020
@csantanapr
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2020
@csantanapr
Copy link
Member

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csantanapr, julz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit a8cf842 into knative:master Nov 24, 2020
@csantanapr
Copy link
Member

@julz could you cherry-pick this to the branch release-0.19?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants