Skip to content

Conversation

julz
Copy link
Contributor

@julz julz commented Nov 25, 2020

Cherry-pick of #3030 for 1.19.

/assign @abrennan89 @csantanapr

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 25, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 25, 2020
@abrennan89
Copy link
Contributor

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, julz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csantanapr
Copy link
Member

Thank you @abrennan89 for reviewing this PR

@knative-prow-robot knative-prow-robot merged commit 96ca603 into knative:release-0.19 Nov 25, 2020
> Note this will not work with HTTP01 either via cert-manager or the net-http01
> options.
{{% tab name="DomainMapping CRD" %}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a {{< /tab >}} before this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants