Skip to content

update package, fix issue 3135 #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2021
Merged

update package, fix issue 3135 #3136

merged 1 commit into from
Jan 11, 2021

Conversation

@vaikas
Copy link
Contributor

@vaikas vaikas commented Jan 11, 2021

Fixes #issue-number or description of the problem the PR solves

Proposed Changes

After this change:

vaikas@vaikas-a01 cloudevents-nodejs % npm audit fix

up to date, audited 377 packages in 2s

found 0 vulnerabilities

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 11, 2021
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 11, 2021
@vaikas
Copy link
Contributor Author

vaikas commented Jan 11, 2021

@lance Would you mind taking a look?

matzew
matzew approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2021
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jan 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 23533ca into knative:master Jan 11, 2021
@vaikas vaikas deleted the issue-3135 branch January 11, 2021 15:43
@csantanapr csantanapr mentioned this pull request Feb 13, 2021
Merged
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Mar 6, 2021
@vaikas @RichieEscarez
update package, fix issue 3135 (knative#3136)
8842695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@vagababov vagababov Awaiting requested review from vagababov

Assignees

@matzew matzew

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix the CVE in sample library dependency.

3 participants

@vaikas @knative-prow-robot @matzew