Skip to content

Conversation

@csantanapr
Copy link
Member

Closes #3247

The following PR #3136 updated the cloudevent SDK from version 3.x to 4.x and this is a major semantic version, which caused code brakes as the code was not compatible with the new major version of the SDK.
https://github.com/knative/docs/pull/3136/files#diff-8d77ef3aae2dea7cc68b9f32a40ac8f43a211f8f6e7f673d12723ed596eca805R16

Proposed Changes

This PR updates the sample code to be compatible with the new major version of the SDK

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 13, 2021
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved labels Feb 13, 2021
@csantanapr
Copy link
Member Author

/assign @vaikas
/assign @knative/api-core-wg-leads

@csantanapr
Copy link
Member Author

I guess PRs can't be assigned to @knative/api-core-wg-leads github teams.

Assigning to Knative Serving since this is a sample under serving in the docs.
Hope the WG leads move forward this PR to resolution.
/assign @mattmoor
/assign @dprotaso

pinging Ville just for awareness
/unassign @vaikas
cc @vaikas

@mattmoor
Copy link
Member

Try this:

/cc @knative/api-core-wg-leads

@mattmoor
Copy link
Member

Perhaps who can be labeled reviewer depends on who has edit access?

/cc @knative/docs-wg-leads

@knative-prow-robot knative-prow-robot requested a review from a team February 13, 2021 14:38
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csantanapr, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit fb2937d into knative:master Feb 13, 2021
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Mar 6, 2021
yangyunfeng007 pushed a commit to yangyunfeng007/docs that referenced this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serving CloudEvent Sample for nodejs is broken

5 participants