-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix cloudevent-nodejs sample to support SDK 4.0 #3248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cloudevent-nodejs sample to support SDK 4.0 #3248
Conversation
|
/assign @vaikas |
|
I guess PRs can't be assigned to Assigning to Knative Serving since this is a sample under serving in the docs. pinging Ville just for awareness |
|
Try this: /cc @knative/api-core-wg-leads |
|
Perhaps who can be labeled reviewer depends on who has edit access? /cc @knative/docs-wg-leads |
mattmoor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csantanapr, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #3247
The following PR #3136 updated the cloudevent SDK from version 3.x to 4.x and this is a major semantic version, which caused code brakes as the code was not compatible with the new major version of the SDK.
https://github.com/knative/docs/pull/3136/files#diff-8d77ef3aae2dea7cc68b9f32a40ac8f43a211f8f6e7f673d12723ed596eca805R16
Proposed Changes
This PR updates the sample code to be compatible with the new major version of the SDK