Skip to content

Comments

Remove @Harwayne from OWNERS.#3231

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
Harwayne:patch-1
Feb 11, 2021
Merged

Remove @Harwayne from OWNERS.#3231
knative-prow-robot merged 1 commit intoknative:masterfrom
Harwayne:patch-1

Conversation

@Harwayne
Copy link
Contributor

@Harwayne Harwayne commented Feb 9, 2021

Fixes #issue-number or description of the problem the PR solves

Proposed Changes

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 9, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2021
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 9, 2021
@knative-prow-robot
Copy link
Contributor

Hi @Harwayne. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mpetason
Copy link
Contributor

mpetason commented Feb 9, 2021

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2021
Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 995c566 into knative:master Feb 11, 2021
@Harwayne Harwayne deleted the patch-1 branch February 11, 2021 18:38
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Mar 6, 2021
yangyunfeng007 pushed a commit to yangyunfeng007/docs that referenced this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants