Skip to content

Add a warning about experimental features#3803

Merged
knative-prow-robot merged 3 commits into
knative:mkdocsfrom
slinkydeveloper:add_warning_experimental_features
Jun 15, 2021
Merged

Add a warning about experimental features#3803
knative-prow-robot merged 3 commits into
knative:mkdocsfrom
slinkydeveloper:add_warning_experimental_features

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper commented Jun 15, 2021

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Followup of #3676

Proposed Changes

  • Adds a warning specifying that experimental features might break, and a link to the details

@slinkydeveloper
Add a warning about experimental features
e67263e 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 15, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 15, 2021
@slinkydeveloper
Fix trailing space
1a9cc85 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 15, 2021

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: e67263e

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60c8608a86a94800079f22f4

😎 Browse the preview: https://deploy-preview-3803--dev-knative.netlify.app/development/eventing/experimental-features

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 15, 2021 •
edited
Loading

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: ca16a5d

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60c8b01b9cc3f3000756b0d1

😎 Browse the preview: https://deploy-preview-3803--dev-knative.netlify.app/development/eventing/experimental-features

abrennan89
abrennan89 reviewed Jun 15, 2021
View reviewed changes
Comment thread docs/eventing/experimental-features.md Outdated
@slinkydeveloper
Warning
ca16a5d 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
abrennan89
abrennan89 approved these changes Jun 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021
@knative-prow-robot knative-prow-robot merged commit 9a98339 into knative:mkdocs Jun 15, 2021
RichardJJG pushed a commit to RichardJJG/docs that referenced this pull request Jul 1, 2021
@slinkydeveloper @RichardJJG
Add a warning about experimental features (knative#3803)
56a8d82 
* Add a warning about experimental features

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Fix trailing space

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Warning

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
This was referenced Sep 5, 2021
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abrennan89 abrennan89 abrennan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abrennan89 abrennan89

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slinkydeveloper @knative-prow-robot @abrennan89