Skip to content

Conversation

@grayside
Copy link
Contributor

Works towards #456 and makes a minor README update follow-up to #443

Proposed Changes

  • Respect the $PORT environment variable as a default behavior
  • Replace use of var with const
  • Add exclamation mark back to the message!
  • Update the duplicated sample code in the README to match changes
  • Note that the default behavior if no $TARGET variable is set will be 'Hello World'

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 16, 2018
@samodell
Copy link
Contributor

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2018
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grayside, samodell, steren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit e3516ff into knative:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants