Make samples less scary when no env var is provided #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/M
Contributor
Author
|
Looking at the Test failure, I conclude this is not due to my changes. |
Contributor
|
/test pull-knative-docs-integration-tests |
Member
|
/test pull-knative-docs-integration-tests |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, steren The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
The integration test failure was unrelated to this change and due to an issue impacting all PRs in the docs repo that is now fixed. /test pull-knative-docs-integration-tests |
This was referenced Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no env var is provided (for example because the developer only has deployed the code without using the
service.yaml), instead of displaying "Hello World: NOT SPECIFIED", display the more friendly message "Hello Word".This means that when the
TARGETenv var is set, instead of displaying "Hello World: ", the samples will display "Hello ", which seems totally OK.All sample changes have been tested.