Skip to content

Conversation

@josephburnett
Copy link
Contributor

Proposed Changes

@josephburnett josephburnett requested a review from steren October 17, 2018 17:50
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2018
@josephburnett josephburnett assigned steren and unassigned steren Oct 17, 2018
Copy link
Contributor

@steren steren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also fixing the other READMEs!

@josephburnett josephburnett assigned rgregg and unassigned steren Oct 17, 2018
@samodell
Copy link
Contributor

/approve
/lgtm

@rgregg
Copy link
Contributor

rgregg commented Oct 22, 2018

/lgtm
/approve

@samodell samodell added lgtm Indicates that a PR is ready to be merged. approved labels Oct 22, 2018
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephburnett, rgregg, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit d1b78c4 into knative:master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants