Skip to content

Conversation

@creydr
Copy link
Member

@creydr creydr commented Sep 16, 2022

PR fixes:

  • some markdown syntax in the RabbitMQ Broker doc, so the code example is displayed properly (048ba6d)
  • some broker spec indentation in the Broker configuration example (e9eb2d5)
  • use correct target namespace for broker in broker configuration example, as the current namespace depends on the used kubeconfig context (6e41f06)
  • states support for RabbitMQ broker in configuration example (009f6d1)

Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@netlify
Copy link

netlify bot commented Sep 16, 2022

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 009f6d1
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6324704f245c9b0008038c35
😎 Deploy Preview https://deploy-preview-5220--knative.netlify.app/docs/eventing/brokers/broker-developer-config-options
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2022
Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@creydr creydr changed the title Fix markdown syntax in RabbitMQ broker docs Fix markdown issues in broker docs Sep 16, 2022
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2022
Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@creydr creydr changed the title Fix markdown issues in broker docs Fix issues in broker docs Sep 16, 2022
Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment - please check with someone in the Eventing WG that this is true about the broker, I always thought it was the current namespace the user is in, not the literal default namespace, but I might be wrong.

Otherwise lgtm! Happy to approve once this is confirmed.

@abrennan89 abrennan89 added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. triage/needs-eng-input Engineering input is requested kind/eventing hacktoberfest-accepted labels Sep 22, 2022
@abrennan89
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 22, 2022
@abrennan89 abrennan89 removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 22, 2022
@abrennan89
Copy link
Contributor

/cherrypick release-1.7

@knative-prow-robot
Copy link
Contributor

@abrennan89: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor

/approve

@knative-prow
Copy link

knative-prow bot commented Sep 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@knative-prow knative-prow bot merged commit e9bb939 into knative:main Sep 22, 2022
@knative-prow-robot
Copy link
Contributor

@abrennan89: new pull request created: #5240

Details

In response to this:

/cherrypick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member

One comment - please check with someone in the Eventing WG that this is true about the broker, I always thought it was the current namespace the user is in, not the literal default namespace, but I might be wrong.

Yes, this is generally true, it's not the literal default but it is the default namespace in the context which is usually default but it might be differerent.

Otherwise lgtm! Happy to approve once this is confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. hacktoberfest-accepted kind/eventing lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/needs-eng-input Engineering input is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants