-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix issues in broker docs #5220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues in broker docs #5220
Conversation
Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
abrennan89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment - please check with someone in the Eventing WG that this is true about the broker, I always thought it was the current namespace the user is in, not the literal default namespace, but I might be wrong.
Otherwise lgtm! Happy to approve once this is confirmed.
|
/lgtm |
|
/cherrypick release-1.7 |
|
@abrennan89: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@abrennan89: new pull request created: #5240 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Yes, this is generally true, it's not the literal
|
PR fixes: