Skip to content

Conversation

@creydr
Copy link
Member

@creydr creydr commented Sep 22, 2022

In the sequence with broker docs, the following image is used to give an overview of the example sequence:

sequence example description

Anyhow in the examples later the trigger for the broker to the sequence, filters on type: dev.knative.sources.ping:

### Create the Trigger targeting the Sequence
```yaml
apiVersion: eventing.knative.dev/v1
kind: Trigger
metadata:
name: sequence-trigger
spec:
broker: default
filter:
attributes:
type: dev.knative.sources.ping
subscriber:
ref:
apiVersion: flows.knative.dev/v1
kind: Sequence
name: sequence
```

And the trigger for the event-display filters on type: samples.http.mod3:

### Create the Service and Trigger displaying the events created by Sequence
```yaml
apiVersion: serving.knative.dev/v1
kind: Service
metadata:
name: sequence-display
spec:
template:
spec:
containers:
- image: gcr.io/knative-releases/knative.dev/eventing/cmd/event_display
---
apiVersion: eventing.knative.dev/v1
kind: Trigger
metadata:
name: display-trigger
spec:
broker: default
filter:
attributes:
type: samples.http.mod3
subscriber:
ref:
apiVersion: serving.knative.dev/v1
kind: Service
name: sequence-display
---

This PR addresses it and updates the image to show the correct "types" for the filters:

updated

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2022
@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2d2d2f5
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/632c65eabeafde000800bc70
😎 Deploy Preview https://deploy-preview-5229--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@abrennan89
Copy link
Contributor

@knative/eventing-wg-leads please review

@abrennan89 abrennan89 added triage/needs-eng-input Engineering input is requested kind/eventing labels Sep 22, 2022
@csantanapr
Copy link
Member

Thank you @creydr for the fix, the new diagram is correct now
/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2022
@knative-prow
Copy link

knative-prow bot commented Sep 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, csantanapr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2022
@knative-prow knative-prow bot merged commit 9c4c0cd into knative:main Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/eventing lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/needs-eng-input Engineering input is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants