Add knative install on ICP in the doc #580
Conversation
knative-prow-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zxDiscovery If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
needs-ok-to-test
|
Hi @zxDiscovery. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -0,0 +1,171 @@ | |||
| # Knative Install on ICP | |||
There was a problem hiding this comment.
Please use full name instead of acronym.
There was a problem hiding this comment.
+1, we should never use short name for some public document, please use IBM Cloud Private instead.
Also please remove ICP from this document.
| `LoadBalancer` to `NodePort` for the `istio-ingress` service). | ||
|
|
||
| ```shell | ||
| curl -L https://raw.githubusercontent.com/knative/serving/v0.2.1/third_party/istio-1.0.2/istio.yaml \ |
There was a problem hiding this comment.
Is there a reason why you aren't installing Istio in the same way as the other install guides?
|
|
||
| ## Before you begin | ||
|
|
||
| Knative requires a ICP(IBM Cloud Private) cluster v2.1.0.3 or newer. |
There was a problem hiding this comment.
Please add instructions on provisioning a cluster on ICP.
|
|
||
| Knative depends on Istio. Run the following to install Istio. (We are changing | ||
| `LoadBalancer` to `NodePort` for the `istio-ingress` service). | ||
|
|
There was a problem hiding this comment.
Please add numbered steps to these instructions.
|
|
||
| ## Installing Knative Serving | ||
|
|
||
| Next, install [Knative Serving](https://github.com/knative/serving): |
There was a problem hiding this comment.
Please add numbered steps to these instructions.
|
|
||
| The ICP Pod | ||
| ```shell | ||
| # kubectl get psp |
| @@ -0,0 +1,171 @@ | |||
| # Knative Install on ICP | |||
There was a problem hiding this comment.
+1, we should never use short name for some public document, please use IBM Cloud Private instead.
Also please remove ICP from this document.
| `LoadBalancer` to `NodePort` for the `istio-ingress` service). | ||
|
|
||
| ```shell | ||
| curl -L https://raw.githubusercontent.com/knative/serving/v0.2.1/third_party/istio-1.0.2/istio.yaml \ |
| Delete the Kubernetes cluster along with Knative, Istio, and any deployed apps: | ||
|
|
||
| ```shell | ||
| kubectl delete |
| ```shell | ||
| vim knative-clusterrole.yaml | ||
| ``` | ||
| ```shell |
There was a problem hiding this comment.
this is not shell but yaml, ditto for other YAML files.
samodell
added
the
do-not-merge/hold
|
@zxDiscovery Thanks for your PR! Please address Averi and Guang's comments to start. We want to keep these install guides as similar as possible, and there are some global changes pending to the install guides in #565, so you'll want to copy the changes there once they're merged in. Adding a hold for that reason. |
|
There are some mistake on this pull request. So close this and create a new one #618 |
6 participants
Fixes #557
Proposed Changes