Add the doc for install knative on IBMCloudPrivate #618

zxDiscovery · 2018-12-03T06:42:06Z

Fixes #557

Proposed Changes

Add the a new file install/Knative-with-ICP.md
Update the install/README.md

knative-prow-robot · 2018-12-03T06:42:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zxDiscovery
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: richieescarez

If they are not already assigned, you can assign the PR to them by writing /assign @richieescarez in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gyliu513 · 2018-12-03T08:37:21Z

install/Knative-with-ICP.md

+
+This guide walks you through the installation of the latest version of
+[Knative Serving](https://github.com/knative/serving) using pre-built images and
+demonstrates creating and deploying an image of a sample "hello world" app onto


s/"hello world"/hello world

gyliu513 · 2018-12-03T08:37:51Z

install/Knative-with-ICP.md

+
+## Before you begin
+
+Knative requires a [IBM Cloud Private](https://www.ibm.com/cloud/private) cluster v2.1.0.3 or newer. The install step you can find on the IBM Knowledge Center, [Installing IBM Cloud Private Cloud Native, Enterprise, and Community editions](https://www-03preprod.ibm.com/support/knowledgecenter/SSBS6K_3.1.1/installing/install_containers.html)


www-03preprod.ibm.com cannot be accessed externally, please use a released link.

gyliu513 · 2018-12-03T08:38:36Z

install/Knative-with-ICP.md

+  | kubectl apply --filename -
+```
+
+Put the namespaces ``knative-serving``, ``knative-build``, ``knative-monitoring`` and ``knative-eventing`` into pod security policy ``ibm-privileged-psp`` as follows.


one ` is enough.

s/knative-serving/knative-serving

gyliu513 · 2018-12-03T08:41:12Z

install/Knative-with-ICP.md

+
+Create a cluster role for the pod security policy resource. The resourceNames for this role must be the name of the pod security policy that was created previous. Here we use ``ibm-privileged-psp``.
+Create a YAML file for the cluster role.
+```


I'd like you use following command:

cat <<EOF | kubectl apply -f - apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: name: knative-role rules: - apiGroups: - extensions resourceNames: - ibm-privileged-psp resources: - podsecuritypolicies verbs: - use EOF

@samodell What do you think of this?

@averikitsch @samodell this is the most popular way for some document related with Kubernetes command, like Istio, federation etc, please refer to https://istio.io/docs/tasks/traffic-management/circuit-breaking/#configuring-the-circuit-breaker for an example. ;-)

gyliu513 · 2018-12-03T08:43:51Z

install/Knative-with-ICP.md

+
+Set up cluster role binding for the service account in knative namespace. By using this role binding, you can set the service accounts in the namespace to use the pod security policy that you created.
+```
+vim knative-clusterrolebinding.yaml


Ditto as above

gyliu513 · 2018-12-03T08:44:35Z

install/Knative-with-ICP.md

+
+Delete the Knative on [IBM Cloud Private](https://www.ibm.com/cloud/private):
+
+```


Add shell for "````"

install/Knative-with-ICP.md

gyliu513 · 2018-12-03T11:04:25Z

install/Knative-with-ICP.md

+  | sed 's/LoadBalancer/NodePort/' \
+  | kubectl apply --filename -
+```
+> Note: If the `image-security-enforcement` enabled when you install [IBM Cloud Private](https://www.ibm.com/cloud/private). You need to update the [image security policy](https://www.ibm.com/support/knowledgecenter/SSBS6K_3.1.1/manage_images/image_security.html).


I want to see more detail for how to update image-security-enforcement based on knative image location.

The document here should also be 2.1.0.3

gyliu513 · 2018-12-03T11:05:36Z

install/Knative-with-ICP.md

+Create a cluster role for the pod security policy resource. The resourceNames for this role must be the name of the pod security policy that was created previous. Here we use ``ibm-privileged-psp``.
+Create a YAML file for the cluster role.
+```shell
+ cat <<EOF | kubectl apply -f -


Kill the blank space in front of this.

gyliu513 · 2018-12-03T11:05:44Z

install/Knative-with-ICP.md

+
+Set up cluster role binding for the service account in knative namespace. By using this role binding, you can set the service accounts in the namespace to use the pod security policy that you created.
+```shell
+ cat <<EOF | kubectl apply -f - 


Kill the blank space in front of this section.

gyliu513 · 2018-12-03T11:07:29Z

install/Knative-with-ICP.md

+
+## Before you begin
+
+Knative requires a [IBM Cloud Private](https://www.ibm.com/cloud/private) cluster v2.1.0.3 or newer. The install step you can find on the IBM Knowledge Center, [Installing IBM Cloud Private Cloud Native, Enterprise, and Community editions](https://www.ibm.com/support/knowledgecenter/SSBS6K_3.1.1/installing/install_containers.html)


You are mentioning cluster v2.1.0.3, but here you are using 3.1.1 document, so here I'd like you mention this example is using 3.1.1 as example.

gyliu513 · 2018-12-03T11:09:35Z

install/Knative-with-ICP.md

+  | sed 's/LoadBalancer/NodePort/' \
+  | kubectl apply --filename -
+```
+> Note: If the `image-security-enforcement` enabled when you install [IBM Cloud Private](https://www.ibm.com/cloud/private). You need to update the [image security policy](https://www.ibm.com/support/knowledgecenter/SSBS6K_3.1.1/manage_images/image_security.html).


The document here should also be 2.1.0.3

gyliu513 · 2018-12-03T11:10:20Z

install/Knative-with-ICP.md

+
+## Before you begin
+
+Knative requires a [IBM Cloud Private](https://www.ibm.com/cloud/private) cluster v2.1.0.3 or newer. The install step you can find on the IBM Knowledge Center, [Installing IBM Cloud Private Cloud Native, Enterprise, and Community editions](https://www.ibm.com/support/knowledgecenter/SSBS6K_3.1.1/installing/install_containers.html)


Why request cluster v2.1.0.3 or newer?

gyliu513 · 2018-12-03T13:11:41Z

/cc @samodell @averikitsch @RichieEscarez

gyliu513 · 2018-12-04T15:24:05Z

@zxDiscovery please rebase as there are some conflict with master.

Also please run prettier --write <your filename> to format your markdown file as we have just merged the PR for whole docs repo at #620

evankanderson · 2018-12-04T21:47:45Z

I think that Matt will be re-running prettier or a regular basis as well to avoid everyone needing to install those tools.

…

On Tue, Dec 4, 2018 at 7:24 AM Guang Ya Liu ***@***.***> wrote: @zxDiscovery <https://github.com/zxDiscovery> please rebase as there are some conflict with master. Also please run prettier --write <your filename> to format your markdown file as we have just merged the PR for whole docs repo at #620 <#620> — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#618 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHlyN7Jfb4A4rnjOvs8X7yh6Rt89YG9kks5u1pOagaJpZM4Y994X> .

-- Evan Anderson <argent@google.com>

averikitsch · 2018-12-06T18:13:54Z

install/Knative-with-ICP.md

+
+Then edit the image security policy.
+```
+# kubectl edit clusterimagepolicies ibmcloud-default-cluster-image-policy


Remove "#" from all commands.

averikitsch · 2018-12-06T18:16:06Z

install/Knative-with-ICP.md

+  You can use the following command to look up the value to use for the {IP_ADDRESS} placeholder
+  used in the samples:
+  ```shell
+  echo $(ICP cluster ip):$(kubectl get svc knative-ingressgateway --namespace istio-system --output 'jsonpath={.spec.ports[?(@.port==80)].nodePort}')


Can you break this into two lines for readability?

install/Knative-with-ICP.md

gyliu513 · 2018-12-07T12:14:43Z

@zxDiscovery after you resolved the comments for the reviewer, please also ack, such as adding Done to the review comments, so that reviewers will know if their comments are addressed or not.

install/Knative-with-ICP.md

samodell · 2018-12-07T17:47:14Z

install/Knative-with-ICP.md

+
+## Cleaning up
+
+Delete the Knative on [IBM Cloud Private](https://www.ibm.com/cloud/private):


Suggested change

Delete the Knative on [IBM Cloud Private](https://www.ibm.com/cloud/private):

Delete the cluster on [IBM Cloud Private](https://www.ibm.com/cloud/private):

samodell · 2018-12-07T17:48:19Z

install/README.md

 * [Knative Install on OpenShift](Knative-with-OpenShift.md)
 * [Knative Install on Minishift](Knative-with-Minishift.md)
 * [Knative Install on Pivotal Container Service](Knative-with-PKS.md)
+* [Knative Install on IBM Cloud Private](Knative-with-ICP.md)


This list is in alphabetical order; please insert after IBM Cloud Kubernetes Service.

samodell · 2018-12-07T17:50:21Z

install/Knative-with-ICP.md

+
+## Before you begin
+
+Knative requires an [IBM Cloud Private](https://www.ibm.com/cloud/private) cluster v3.1.1. The install step you can find on the IBM Knowledge Center, [Installing IBM Cloud Private Cloud Native, Enterprise, and Community editions](https://www.ibm.com/support/knowledgecenter/SSBS6K_3.1.1/installing/install_containers.html)


"The install step you can find on the IBM Knowledge Center, Installing IBM Cloud Private Cloud Native, Enterprise, and Community editions"

change to:

"See Installing IBM Cloud Private Cloud Native, Enterprise, and Community editions in the IBM Knowledge Center for install instructions."

gyliu513 · 2018-12-10T08:12:09Z

@zxDiscovery Some actions need to take:

Rebase, as there are some conflicts for your PR.
Make sure you ACK all reviewer's comments but not only uploading PRs.
Squash all of your commits to one with squash.

samodell · 2018-12-10T23:45:55Z

/ok-to-test

samodell · 2018-12-11T16:56:10Z

/retest

Signed-off-by: GuessWhoSamFoo <sfoohei@gmail.com>

Change the image name to match the instructions in README.

gyliu513 · 2018-12-12T02:39:43Z

@zxDiscovery please squash your commits to one commit, you can ask @clyang82 for how to squash commits.

Produced via: `prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)`

* Add Docker for Mac setup instructions. * Fix prose and typos. * Add Docker for Mac link to global README.

googlebot · 2018-12-13T08:34:14Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

zxDiscovery · 2018-12-13T09:12:35Z

The local git repository has some problem, I create a new PR to replace the current PR. See #660
So close this.

Add the doc for install knative on IBMCloudPrivate

146e32e

knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 3, 2018

knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 3, 2018

knative-prow-robot requested review from evankanderson and mchmarny December 3, 2018 06:42

zxDiscovery mentioned this pull request Dec 3, 2018

Add knative install on ICP in the doc #580

Closed

gyliu513 reviewed Dec 3, 2018

View reviewed changes

update IBMCloudPrivate doc follow the review commments

a0b6797

gyliu513 reviewed Dec 3, 2018

View reviewed changes

knative-prow-robot requested review from RichieEscarez, averikitsch and samodell December 3, 2018 13:11

update according to the review comments

f4cb15b

averikitsch suggested changes Dec 6, 2018

View reviewed changes

update follow by the review comments

9882adf

gyliu513 reviewed Dec 7, 2018

View reviewed changes

install/Knative-with-ICP.md Show resolved Hide resolved

samodell suggested changes Dec 7, 2018

View reviewed changes

zxDiscovery added 3 commits December 10, 2018 15:36

update doc according to the review comments

03da0c1

Update Format

e820b54

Format update

71f5653

zxDiscovery added 2 commits December 10, 2018 16:15

Format update

194a01e

Format update

e1b7485

knative-prow-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 10, 2018

zxDiscovery added 2 commits December 11, 2018 09:49

merge master branch

ef708ae

Merge branch 'master' into Add-ICP-doc

6ebdef1

GuessWhoSamFoo and others added 2 commits December 11, 2018 12:47

Remove repeated words (knative#654)

b75f11a

Signed-off-by: GuessWhoSamFoo <sfoohei@gmail.com>

Update service.yaml in the gitwebhook sample (knative#648)

7f185c4

Change the image name to match the instructions in README.

mattmoor-sockpuppet and others added 12 commits December 12, 2018 08:47

Format markdown (knative#658)

ef7ef10

Produced via: `prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)`

Add Docker for Mac setup instructions. (knative#627)

9530cae

* Add Docker for Mac setup instructions. * Fix prose and typos. * Add Docker for Mac link to global README.

Add the doc for install knative on IBMCloudPrivate

bd84cdb

update IBMCloudPrivate doc follow the review commments

ec776ab

update according to the review comments

2255649

update follow by the review comments

b37f838

update doc according to the review comments

fa55726

Update Format

37382d0

Format update

8f03e80

Format update

694a9cb

Format update

a3d46df

update README.md

3c1f8ce

zxDiscovery closed this Dec 13, 2018

zxDiscovery mentioned this pull request Dec 13, 2018

Update doc for knative deploy on IBMCloudPrivate #660

Merged

zxDiscovery deleted the Add-ICP-doc branch February 11, 2019 13:50


		## Before you begin

		Knative requires a [IBM Cloud Private](https://www.ibm.com/cloud/private) cluster v2.1.0.3 or newer. The install step you can find on the IBM Knowledge Center, [Installing IBM Cloud Private Cloud Native, Enterprise, and Community editions](https://www-03preprod.ibm.com/support/knowledgecenter/SSBS6K_3.1.1/installing/install_containers.html)


		Delete the Knative on [IBM Cloud Private](https://www.ibm.com/cloud/private):

		```


		## Cleaning up

		Delete the Knative on [IBM Cloud Private](https://www.ibm.com/cloud/private):

	Delete the Knative on [IBM Cloud Private](https://www.ibm.com/cloud/private):
	Delete the cluster on [IBM Cloud Private](https://www.ibm.com/cloud/private):


		## Before you begin

		Knative requires an [IBM Cloud Private](https://www.ibm.com/cloud/private) cluster v3.1.1. The install step you can find on the IBM Knowledge Center, [Installing IBM Cloud Private Cloud Native, Enterprise, and Community editions](https://www.ibm.com/support/knowledgecenter/SSBS6K_3.1.1/installing/install_containers.html)

Add the doc for install knative on IBMCloudPrivate #618

Add the doc for install knative on IBMCloudPrivate #618

Uh oh!

Conversation

zxDiscovery commented Dec 3, 2018

Proposed Changes

Uh oh!

knative-prow-robot commented Dec 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gyliu513 commented Dec 3, 2018

Uh oh!

gyliu513 commented Dec 4, 2018

Uh oh!

evankanderson commented Dec 4, 2018 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gyliu513 commented Dec 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gyliu513 commented Dec 7, 2018 •

edited

Loading

gyliu513 commented Dec 10, 2018 •

edited

Loading