Skip to content

Conversation

@Leo6Leo
Copy link
Member

@Leo6Leo Leo6Leo commented Apr 25, 2024

This PR contains a draft of the first post in the blog series we proposed recently to make it easier for new contributors to contribute code. The proposal can be seen here

Proposed Changes

  • Create post 3: API Changes

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 25, 2024
@knative-prow knative-prow bot requested review from nainaz and skonto April 25, 2024 13:09
@netlify
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9f7f92c
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/66588fc168cf4500083580d7
😎 Deploy Preview https://deploy-preview-5949--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Leo6Leo
Copy link
Member Author

Leo6Leo commented Apr 25, 2024

/cc @Cali0707 @pierDipi @creydr

@knative-prow knative-prow bot requested review from Cali0707, creydr and pierDipi April 25, 2024 13:10
@Leo6Leo Leo6Leo requested a review from Cali0707 April 25, 2024 13:38
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start @Leo6Leo !

Just a couple changes needed for clarity/better rendering and then we should be good to go here!

Co-authored-by: Calum Murray <cmurray@redhat.com>
@nainaz
Copy link
Contributor

nainaz commented May 15, 2024

Great start and left some comments.
Maybe that was the intention of the blog post but to me it felt that it ended abruptly. I didn't "see" any result or output.
I just changed a file, got suggestion to change the other file but then to what end.

@Cali0707
Copy link
Member

Maybe that was the intention of the blog post but to me it felt that it ended abruptly. I didn't "see" any result or output.

@nainaz that's a great point, we should probably improve the conclusion a bit

The idea is that readers would then continue to the future blog posts we are working on and make the rest of the required changes there. But, I can see how that could be unclear or leave someone unsatisfied reading the current post.

@nainaz
Copy link
Contributor

nainaz commented May 15, 2024 via email

@Leo6Leo Leo6Leo requested a review from Cali0707 May 30, 2024 12:41
Co-authored-by: Calum Murray <cmurray@redhat.com>
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @Leo6Leo !!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
@knative-prow
Copy link

knative-prow bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ac232e2 into knative:main May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants