Skip to content

Conversation

@ankitajana21
Copy link
Member

@ankitajana21 ankitajana21 commented Feb 12, 2025

fixes #6224
Some of the links in Bookstore Sample App (https://github.com/knative/docs/tree/main/code-samples/eventing/bookstore-sample-app) were broken. Checked and fixed all the broken links. All the links now redirect user to the correct destination.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 12, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot requested review from csantanapr and skonto February 12, 2025 16:57
@knative-prow
Copy link

knative-prow bot commented Feb 12, 2025

Welcome @ankitajana21! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 12, 2025
@netlify
Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ae2f28e
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/67acd2f9796fda000869f080
😎 Deploy Preview https://deploy-preview-6225--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ankitajana21
Copy link
Member Author

/cc @Leo6Leo

@knative-prow knative-prow bot requested a review from Leo6Leo February 12, 2025 17:23
@Leo6Leo
Copy link
Member

Leo6Leo commented Feb 12, 2025

Thanks for the PR! @ankitajana21

Could you please update the title and the description of the PR so that it become more descriptive?

You can take a look here to get some insight.

@ankitajana21 ankitajana21 changed the title Fixed issue #6224 Updated the links in Bookstore Sample App Feb 12, 2025
@ankitajana21
Copy link
Member Author

@Leo6Leo I have updated the title and the description.

@Leo6Leo
Copy link
Member

Leo6Leo commented Feb 12, 2025

/approve
/lgtm

Thanks @ankitajana21 ! And congrats on your very first PR in Knative.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2025
@knative-prow
Copy link

knative-prow bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitajana21, Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@knative-prow knative-prow bot merged commit f35bf06 into knative:main Feb 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The links in the sample app redirect to the wrong place

2 participants