-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Updated the links in Bookstore Sample App #6225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The committers listed above are authorized under a signed CLA. |
|
Welcome @ankitajana21! It looks like this is your first PR to knative/docs 🎉 |
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/cc @Leo6Leo |
|
Thanks for the PR! @ankitajana21 Could you please update the title and the description of the PR so that it become more descriptive? You can take a look here to get some insight. |
|
@Leo6Leo I have updated the title and the description. |
|
/approve Thanks @ankitajana21 ! And congrats on your very first PR in Knative. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitajana21, Leo6Leo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #6224
Some of the links in Bookstore Sample App (https://github.com/knative/docs/tree/main/code-samples/eventing/bookstore-sample-app) were broken. Checked and fixed all the broken links. All the links now redirect user to the correct destination.