Skip to content

Conversation

@dprotaso
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Aug 20, 2025

Deploy Preview for knative ready!

Name Link
🔨 Latest commit 401ef58
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/68a648e690459e0008fccca5
😎 Deploy Preview https://deploy-preview-6348--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 20, 2025
@dprotaso
Copy link
Member Author

/assign @Cali0707

Co-authored-by: Calum Murray <cmurray@redhat.com>
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025
@knative-prow
Copy link

knative-prow bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707
Copy link
Member

/cherry-pick release-1.19

@knative-prow-robot
Copy link
Contributor

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit ebd4cfe into knative:main Aug 21, 2025
19 checks passed
@knative-prow-robot
Copy link
Contributor

@Cali0707: #6348 failed to apply on top of branch "release-1.19":

Applying: Drop 1.19 from version drop-down due to OTel issues & warn folks on the blog
Using index info to reconstruct a base tree...
A	blog/docs/releases/announcing-knative-v1-19-release.md
M	hack/build.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/build.sh
CONFLICT (content): Merge conflict in hack/build.sh
CONFLICT (modify/delete): blog/docs/releases/announcing-knative-v1-19-release.md deleted in HEAD and modified in Drop 1.19 from version drop-down due to OTel issues & warn folks on the blog. Version Drop 1.19 from version drop-down due to OTel issues & warn folks on the blog of blog/docs/releases/announcing-knative-v1-19-release.md left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Drop 1.19 from version drop-down due to OTel issues & warn folks on the blog

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso dprotaso deleted the otel-1.19-skip branch August 21, 2025 02:37
@dprotaso
Copy link
Member Author

I don;t think we need to cherry-pick since we build from main

dprotaso added a commit to dprotaso/knative-docs that referenced this pull request Sep 12, 2025
knative-prow bot pushed a commit that referenced this pull request Sep 12, 2025
…lks on the blog (#6348)" (#6370)

* Revert "Drop 1.19 from version drop-down due to OTel issues & warn folks on the blog (#6348)"

This reverts commit ebd4cfe.

* bump node and python versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants