-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Revise Security and Threat Disclosure page #6472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise Security and Threat Disclosure page #6472
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/assign @evankanderson |
evankanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! A few comments, since things moved between when the issue was filed and when you took it on.
| # Knative Security and Disclosure Information | ||
|
|
||
| This page describes Knative security and disclosure information. | ||
| This page describes how to validate code and report security vulnerabilities in Knative.For a complete description of the Knative threat model, see the following resource: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This page describes how to validate code and report security vulnerabilities in Knative.For a complete description of the Knative threat model, see the following resource: | |
| This page describes how to validate code and report security vulnerabilities in Knative. For a complete description of the Knative threat model, see the following resource: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one also corrected as per your suggestion
| about the provenance of those binaries. | ||
|
|
||
| ## Code Signature Verification | ||
| ## Verifying a Code Signature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "binary signature" would make more sense here:
| ## Verifying a Code Signature | |
| ## Verifying a Binary Signature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified code to Binary
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, skmahe1077 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #6308
This PR updates the Security and Threat Disclosure page for clarity and consistency across the Knative Docs site, based on the recommendations in issue #6308