Skip to content

Conversation

@skmahe1077
Copy link
Contributor

Fixes #6308
This PR updates the Security and Threat Disclosure page for clarity and consistency across the Knative Docs site, based on the recommendations in issue #6308

@netlify
Copy link

netlify bot commented Oct 26, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6b38419
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/690128035e3fb200089f559f
😎 Deploy Preview https://deploy-preview-6472--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot requested review from Cali0707 and skonto October 26, 2025 23:08
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2025
@Cali0707
Copy link
Member

/assign @evankanderson

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! A few comments, since things moved between when the issue was filed and when you took it on.

# Knative Security and Disclosure Information

This page describes Knative security and disclosure information.
This page describes how to validate code and report security vulnerabilities in Knative.For a complete description of the Knative threat model, see the following resource:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This page describes how to validate code and report security vulnerabilities in Knative.For a complete description of the Knative threat model, see the following resource:
This page describes how to validate code and report security vulnerabilities in Knative. For a complete description of the Knative threat model, see the following resource:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also corrected as per your suggestion

about the provenance of those binaries.

## Code Signature Verification
## Verifying a Code Signature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "binary signature" would make more sense here:

Suggested change
## Verifying a Code Signature
## Verifying a Binary Signature

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified code to Binary

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2025
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 28, 2025
@evankanderson
Copy link
Member

/lgtm
/approve

@knative-prow
Copy link

knative-prow bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, skmahe1077

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f4022d6 into knative:main Oct 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revise the Security and threat disclosure page

3 participants