Skip to content

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Nov 17, 2025

Image pushing was failing due to bad path

  • update autoscaling README.md docs
  • update image workflow to continue even if failure occurs

Related: #6501 (comment)

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 17, 2025
@knative-prow knative-prow bot requested review from Cali0707 and skonto November 17, 2025 16:06
@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for knative ready!

Name Link
🔨 Latest commit 3172fc5
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/691b480bb46ec60008b2598f
😎 Deploy Preview https://deploy-preview-6508--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Leo6Leo
Copy link
Member

Leo6Leo commented Nov 17, 2025

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit e2d5db9 into knative:main Nov 17, 2025
19 checks passed
@dprotaso dprotaso deleted the fix-image-workflows branch November 17, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants