Skip to content

fix image workflows #6508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2025
Merged

fix image workflows #6508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e42fe25
update autoscaling README.md docs
dprotaso Nov 17, 2025
3172fc5
update image workflow to continue even if failure occurs
dprotaso Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/knative-docs-image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,15 @@ jobs:

- name: Build mkdocs image
uses: docker/build-push-action@v6
continue-on-error: true
with:
push: true
file: ./hack/docker/Dockerfile
tags: ghcr.io/knative/knative-docs:latest

- name: Build helloworld-go image
uses: docker/build-push-action@v6
continue-on-error: true
with:
push: true
platforms: linux/amd64,linux/arm64,linux/ppc64le,linux/s390x
Expand All @@ -50,14 +52,16 @@ jobs:

- name: Build autoscale-go image
uses: docker/build-push-action@v6
continue-on-error: true
with:
push: true
platforms: linux/amd64,linux/arm64,linux/ppc64le,linux/s390x
context: ./docs/serving/autoscaling/autoscale-go
context: ./docs/versioned/serving/autoscaling/autoscale-go
tags: ghcr.io/knative/autoscale-go:latest

- name: Build sample-app's frontend image
uses: docker/build-push-action@v6
continue-on-error: true
with:
push: true
platforms: linux/amd64,linux/arm64
Expand All @@ -66,6 +70,7 @@ jobs:

- name: Build sample-app's node-server image
uses: docker/build-push-action@v6
continue-on-error: true
with:
push: true
platforms: linux/amd64,linux/arm64
Expand Down
4 changes: 2 additions & 2 deletions docs/versioned/serving/autoscaling/autoscale-go/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ A demonstration of the autoscaling capabilities of a Knative Serving Revision.
1. Deploy the [sample](service.yaml) Knative Service:

```bash
kubectl apply -f docs/serving/autoscaling/autoscale-go/service.yaml
kubectl apply -f docs/versioned/serving/autoscaling/autoscale-go/service.yaml
```

1. Obtain the URL of the service (once `Ready`):
Expand Down Expand Up @@ -255,7 +255,7 @@ customization (32 minutes).
## Cleanup

```bash
kubectl delete -f docs/serving/autoscaling/autoscale-go/service.yaml
kubectl delete -f docs/versioned/serving/autoscaling/autoscale-go/service.yaml
```

## Further reading
Expand Down
Loading