Skip to content

Conversation

@Kunal1522
Copy link

Fixes knative/func#3299

Proposed Changes

  • Added documentation for FUNC_USERNAME and FUNC_PASSWORD environment variables in docs/snippets/proc-building-function.md.
  • Added documentation for FUNC_USERNAME and FUNC_PASSWORD environment variables in docs/snippets/proc-deploying-function.md.
  • Clarified that these environment variables now work with all builders (host, s2i, and pack) for private registry authentication, following the refactoring in knative/func#3298.
  • Since these are snippets, the updates will automatically appear in the "Building functions", "Deploying functions", and "Getting started" documentation pages.

@netlify
Copy link

netlify bot commented Dec 18, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bff0eea
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/69440c60502b700007c8a2d0
😎 Deploy Preview https://deploy-preview-6543--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 18, 2025

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Kunal1522 / name: Kunal Kashyap (bff0eea)

@knative-prow
Copy link

knative-prow bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kunal1522
Once this PR has been reviewed and has the lgtm label, please assign lkingland for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
Copy link

knative-prow bot commented Dec 18, 2025

Welcome @Kunal1522! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 18, 2025
@Cali0707
Copy link
Member

/cc @gauron99 @lkingland

@knative-prow knative-prow bot requested review from gauron99 and lkingland December 18, 2025 16:40
@gauron99
Copy link
Contributor

Thanks for the ping. I commented on the mentioned issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add release note and docs to credentials refactoring.

3 participants