Tweaks docs to create Istio CRDs first #717
Conversation
knative-prow-robot
added
the
size/XS
install/Knative-with-IKS.md
Outdated
| `istio.yaml` (which includes those CRD definitions) fails due to the CRD | ||
| controller not defining those types by the time we try to use them: | ||
| ```bash | ||
| kubectl apply --filename https://github.com/knative/serving/releases/download/v0.2.2/istio-crds.yaml |
There was a problem hiding this comment.
IMO at this point we should list this command like:
1 && \
2 && \
3
so that if people copy-paste all of this code block, it stops on failure.
Also I wonder if you still see errors when you don't add the sleep 10 (I feel like applying CRDs first is already a big improvement on the success rate).
There was a problem hiding this comment.
Will add the &&'s
And then test w/o the sleep....
|
Shouldn't this change be replicated on other cloud platforms as well? As far as I can tell, Istio installation race issues aren't specific to IKS. |
|
Yep - I mentioned in the initial comment that once we get the text right, and people are ok with it, I can make the same change to the others. |
sorry for not seeing it, my bad |
install/Knative-with-IKS.md
Outdated
| Install the Istio CRDs first so that Kubernetes has time to create | ||
| the resource definitions. Sometimes the deployment of `istio.yaml` | ||
| (which includes those CRD definitions) fails because the types are | ||
| have not finished being defined by the CRD controller. |
There was a problem hiding this comment.
If the istio.yaml deployment fails, what should you do? Wait and try again? If so, can we include that instruction?
There was a problem hiding this comment.
Was wondering how verbose I should get on this w/o being annoying :-) But let me add something and then you guys can check it out....
Closes knative#540 If people are ok with this change I'll make similar modifications to the other instruction files too. Signed-off-by: Doug Davis <dug@us.ibm.com>
knative-prow-robot
added
size/S
|
ok I think it did all of the updates. In my testing just pulling out the CRDs (so no "sleep") is sufficient. Please take a took and see if the more verbose text is ok. |
knative-prow-robot
added
size/XS
|
@carieshmarie did you push to my PR/branch? While I'm ok with your suggested change, I would prefer if you added it as a suggested edit so I can review it rather than to just push to my branch. |
|
Sorry, @duglin - I meant to include a comment with an overview of what I was doing, but got sidelined. Apologies for the commit out of nowhere. If you're ok with the change, then I think it's ready to be applied more broadly. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: duglin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No worries - will work on the other docs now... |
Continuation of knative#717 - get the rest of the install docs Signed-off-by: Doug Davis <dug@us.ibm.com>
Continuation of knative#717 - get the rest of the install docs Signed-off-by: Doug Davis <dug@us.ibm.com>
Continuation of #717 - get the rest of the install docs Signed-off-by: Doug Davis <dug@us.ibm.com>
4 participants
Fixes #540
If people are ok with this change I'll make similar modifications to the other
instruction files too.
Signed-off-by: Doug Davis dug@us.ibm.com